Skip to content

i18n: extract the conflict modals and the Settings page - #124

Open
Janlhin wants to merge 3 commits into
Liquid-co:dev-publicfrom
Janlhin:pr-3-conflicts-and-settings
Open

Janlhin wants to merge 3 commits into
Liquid-co:dev-publicfrom
Janlhin:pr-3-conflicts-and-settings

Conversation

@Janlhin

@Janlhin Janlhin commented Oct 25, 2026 •

Copy link
Copy Markdown

What

Extracts the user-facing strings of the two conflict modals (save-conflict
and location-conflict) and the whole Settings page into the catalog
(en / zh-Hans / zh-Hant), one key per sentence, grouped per component.
Three commits, one per area: the conflict modals, then Settings
(script / header / tabs / general + sync), then Settings
(storage / advanced / support).

Notes

  • Based on the current dev-public (7e4310b), per the rebase-onto-latest
    rule. The UI strings upstream added since this work's branch point (Track a game from the game database; one folder, one game #73's
    Track game set and the later ones) are kept as-is — this PR only adds keys:
    549 keys per language after it (344 + 205), 0 removed, 0 reworded.
  • Both Chinese scripts in the same commits, keys aligned after every single
    commit (0 missing / 0 extra), so each commit is bisect-clean.
  • Plurals go through Intl.PluralRules; Chinese uses the single form.
  • Inline-bold sentences use segments() as in Home; no hintA/hintB splits.
  • The Settings controller, notifications, snapshot-check and storage-usage
    panels stay as they are — a separate follow-up.
  • Verified: npm test 336/336 · vite build clean · every $t reference in
    the tree resolves to a catalog key (checked, not assumed) · the new keys'
    values are present in the built bundle.

Verification

  • npm test 336/336 · vite build clean · every $t reference in the tree
    resolves to a catalog key (checked programmatically) · the new keys' values
    are present in the built bundle (205/205).
  • Not yet done, flagged rather than claimed: a click-through of the built app
    (Settings' extracted tabs and both conflict modals, in both scripts) — that
    one needs the running app, so it stays on my list before this is called
    fully walked.

Translation and review: @Janlhin (simplified & traditional)

@vercel

vercel Bot commented Oct 25, 2026

Copy link
Copy Markdown

Someone is attempting to deploy a commit to the sivadaboi's projects Team on Vercel.

A member of the Team first needs to authorize it.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant