Repository navigation
Conversation
|
Someone is attempting to deploy a commit to the sivadaboi's projects Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Extracts the user-facing strings of the two conflict modals (save-conflict
and location-conflict) and the whole Settings page into the catalog
(en / zh-Hans / zh-Hant), one key per sentence, grouped per component.
Three commits, one per area: the conflict modals, then Settings
(script / header / tabs / general + sync), then Settings
(storage / advanced / support).
Notes
dev-public(7e4310b), per the rebase-onto-latestrule. The UI strings upstream added since this work's branch point (Track a game from the game database; one folder, one game #73's
Track game set and the later ones) are kept as-is — this PR only adds keys:
549 keys per language after it (344 + 205), 0 removed, 0 reworded.
commit (0 missing / 0 extra), so each commit is bisect-clean.
segments()as in Home; no hintA/hintB splits.panels stay as they are — a separate follow-up.
npm test336/336 ·vite buildclean · every$treference inthe tree resolves to a catalog key (checked, not assumed) · the new keys'
values are present in the built bundle.
Verification
npm test336/336 ·vite buildclean · every$treference in the treeresolves to a catalog key (checked programmatically) · the new keys' values
are present in the built bundle (205/205).
(Settings' extracted tabs and both conflict modals, in both scripts) — that
one needs the running app, so it stays on my list before this is called
fully walked.
Translation and review: @Janlhin (simplified & traditional)