Repository navigation
Conversation
The zh-Hant catalog still carried the Simplified spelling 跟踪 in the five keys of the Track game feature (home.trackGame and four home.findGame.* keys), while the rest of the catalog uses 跟蹤. The regression came from my own review pass in Liquid-co#77 (82e95c5): polishing the strings ported from Liquid-co#73 reverted them to the Simplified spelling. The Liquid-co#112 sweep (858d71a) fixed the neighbouring home.addGame.title but missed these five. Omar-VF asked for them in the next PR (Liquid-co#112 review). Only the glyph changes — placeholders and wording are untouched. Not in scope here (lib-layer batch): StatusBar's "Syncing is paused …" tooltip and its visible label stay hardcoded English because lib/syncpause.js (pauseLength, pauseShort, PAUSE_CHOICES, the pause/resume toasts) is still English-only; extracting the wrapper sentences alone would ship mixed-language UI.
|
Someone is attempting to deploy a commit to the sivadaboi's projects Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Corrects the zh-Hant (Traditional) catalog: the five keys of the Track game
feature still carried the Simplified spelling 跟踪 while the rest of the
catalog uses 跟蹤. Glyph-only change — no wording, placeholder or key
changes, en and zh-Hans untouched.
home.trackGamehome.findGame.titlehome.findGame.trackedAshome.findGame.noSavesYethome.findGame.alreadyNotes
from my own review pass in i18n: offer Chinese by script (zh-Hans/zh-Hant) and extract the window shell #77 (82e95c5), which polished the strings ported
from Track a game from the game database; one folder, one game #73 and reverted these five to the Simplified spelling; the i18n: extract the shared components #112 sweep
(858d71a) fixed the neighbouring
home.addGame.titlebut missed them.npm test336/336 ·vite buildclean · the three catalogs stayaligned (344 keys each, 0 missing / 0 extra).
StatusBar's "Syncing is paused …" tooltip and its visible label, because
lib/syncpause.js(pauseLength / pauseShort / PAUSE_CHOICES / thepause-resume toasts) is English-only — extracting the wrapper sentences
alone would ship mixed-language UI.
Translation and review: @Janlhin (simplified & traditional)