Repository navigation
A backup folder that is not connected is not written to - #119
Merged
Merged
Conversation
A network share that is not connected leaves its mount point behind: an empty folder, or none. Backups to a local-folder destination on such a share were written into it, onto this machine's own disk, and counted as sent, while the share never got them (#46). A backup folder that was gone was created again by the next backup, with the same result. A local backup folder is now marked when it is chosen in Cloud Backup: created if need be, with a small file (.opensave-backup-folder) that says it is OpenSave's backup folder. A backup, and a look at what the folder holds, goes ahead only when the folder is there and marked. Otherwise it fails saying the folder is not available, check that the drive or share is connected, and the backup is sent again at a later cloud check, as any failed backup is. A folder chosen before the marker existed that already holds OpenSave's backups is marked the first time it is used, so nobody has to choose their folder again.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Seagulls
pushed a commit
to Seagulls/OpenSave
that referenced
this pull request
Oct 25, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the remaining part of #46. A local-folder backup destination on a network share that isn't connected used to accept backups: they were written into the empty mount point (or a recreated folder) on this machine's own disk and counted as sent, while the share never got them. (#47 already fixed the listing side.)
.opensave-backup-folder) when it is chosen in Cloud Backup, and created if needed.Tests:
internal/cloud/provider_local_marker_test.go.