Repository navigation
sync: the snapshot after a pull reuses unchanged files and records them - #116
Merged
Omar-VF merged 1 commit intoOct 23, 2026
Merged
Conversation
The snapshot recorded under the other device's id after a pull compressed the whole save from scratch, and recorded no file list, so the next snapshot here could not reuse it either. A save of a quarter-million files sat at "100%" for minutes after its download had finished. It is now archived like any snapshot here (Manager.ArchiveSaveTo): files unchanged since the branch's newest snapshot are copied from it, and what it holds is recorded. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@ChakraFusion is attempting to deploy a commit to the sivadaboi's projects Team on Vercel. A member of the Team first needs to authorize it. |
Seagulls
pushed a commit
to Seagulls/OpenSave
that referenced
this pull request
Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a pull, the snapshot recorded under the other device's id (
recordMirrorSnapshot) compressed the whole save from scratch withZipRoots. It also recorded no file list, so the next snapshot here couldn't reuse it either (openReuseSourceneeds one). With a save of a quarter-million files, the app sat at "100%" for minutes after the download had finished.The change: it is archived the way any snapshot here is, through a new
Manager.ArchiveSaveTo. Files unchanged since the branch's newest snapshot are copied from it (reuse.go), and what it holds is recorded (RecordSnapshotFiles).Tests:
TestArchiveSaveToReusesUnchangedFiles: 19 of 20 entries are copied when a pull changed one.TestSync_TheSnapshotAfterAPullRecordsItsFiles: the snapshot after a pull records its files. This fails without the change ("records 0 file(s)").Checks: the full unit and e2e suites pass locally on today's
dev-public.🤖 Generated with Claude Code