Repository navigation
fix(tileop): complete atomic TSTORE and cooperative TMOV contracts - #298
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LLVM dependency
Validated with LinxISA/llvm-project dev-llvm15_56 commit
2113a9922e5271592d7022f4888edba3d264d007, which contains the #398 Atomic TSTORE encoding and #399 CUBE capacity/conversion/transport support.Verification
python3 test/test_issue_398_399_contract.py: 4 passedtest/test_predicate_adapters.py: 17 passedTStoreAtomic.oandCubeToSharedND.ogenerated successfullyB.IOT,PredInv, Shared PE mask, and assembled valid shapeLB0=3, LB1=64, LB2=4git diff --check: passedExisting gate failures
The full target object gate reports 86 passed and 23 unrelated existing failures, including retired fixtures and LLVM Shared-handle backend restrictions. Host
make checkreaches an existingElementTile<unsigned long>expectation failure; the focused #398/#399 checks pass.