Repository navigation
Add experimental typed PredicateCell producer/consumer adapters - #295
Merged
Merged
Conversation
Collaborator
Author
|
Model capability follow-up: LinxISA/SuperScalarModel#1131 now tracks the pinned-main non-TCI ExecutionMask rejection and multi-column CUBE PredicateCell explicit-mask gap. Existing FP32 timing capability remains #1046. Do not treat this PR or MC roundtrip validation as model end-to-end acceptance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add experimental explicit TileOP PredicateCell producer/consumer adapters. This is not an element-if-only API and does not export/import element-if implicit masks.
Predicate<Basis>carrier;compare_scalar<Mode>produces CUBE PredicateCell.scatterbinds PredicateCell directly to MSCATTER_MASK without TCVT.atomic_add<Invert>uses MSCATTER_ADD ExecutionMask, not a new operation-owned source mask. Requires LLVM commitdb000947b0cdf9c128d3880bb23ca7daac34d81a, already pushed to LinxISA/llvm-project dev-llvm15_56.Related: PTO-ISA/pto-spec#349 (not closed; broader composition/spec wording questions remain).
Validation
Model boundary
No model/ISA assertions changed. No model numerical or TopK RES_CHECK PASS claimed. Current SuperScalarModel main has an explicit non-TCI ExecutionMask rejection and multi-column CUBE explicit-mask restriction; these are tracked separately, not patched or bypassed here. FP32 timing capability is already tracked by SuperScalarModel #1046.
Please merge only after required CI is green; do not bypass the gate.