Skip to content

fix(EventSubscribers): ensure signature loaded for signing #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakeaturner merged 1 commit into from
Sep 24, 2026
Merged

fix(EventSubscribers): ensure signature loaded for signing #315

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion server/controllers/EventSubscriberController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,12 @@ export class EventSubscriberController {
): Promise<EventSubscriber[]> {
try {
const columnName = this.getColumnName(event);
const eventSubscribers = await EventSubscriber.findAll({
// unscoped: the DefaultScope on this model excludes signing_key, and
// signAndSend needs it to sign deliveries. Without this the key reads back
// as undefined and jose signs HS256 with zero bytes, producing tokens no
// subscriber can verify. Safe to unscope here because the only caller is
// EventSubscriberEmitter, so the key never reaches an API response.
const eventSubscribers = await EventSubscriber.unscoped().findAll({
include: [
{
model: EventSubscriberEventConfig,
Expand Down
Loading