Repository navigation
🔢 docs: Clarify That sharedCacheSlots Is a Maximum - #843
Merged
Merged
Conversation
"Most Redis keys" read as "the majority of" to the translator, so the Korean page states the opposite of the limit.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
📦 Next.js Bundle Analysis for librechat.aiThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
sharedCacheSlotsdescription began with "Most Redis keys the shared cache uses", meaning an upper bound. The translator read "most" as "the majority of", so the Korean page currently says the opposite of a limit. The sentence now says "Maximum number of Redis keys", and spells out that the limit applies to results and again to rate limit cooldowns. Changing the English line retranslates it in every locale on the next translation run.Change Type
Testing
prettier --checkon the page: clean.automation/docs-translationsthat showed the misreading (대부분 instead of a maximum).Checklist