Repository navigation
Conversation
…ts with system libjpeg-turbo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #729.
Problem
When an application links against both
libvncserverand systemlibjpeg-turbo(directly or indirectly), calling TurboJPEG functions (liketjCompress2,tjDecompress, etc.) resolves tolibvncserver's internal embedded implementation instead of systemlibjpeg-turbodue to exported symbol collision. This causes unexpected behaviors and potential crashes in downstream applications.Solution
Prefix internal TurboJPEG function names and macros with
rdr_(rdr_tjInitCompress,rdr_tjCompress2,rdr_tjDecompress, etc.) insrc/common/turbojpeg.h,src/common/turbojpeg.c, and internal consumers (src/libvncserver/tight.c,src/libvncclient/tight.c,src/libvncclient/vncviewer.c, and tests).Verification
libvncservervia CMake.readelf -Ws build/libvncserver.so | grep tjand verified no globaltj*symbols are exported.ctest), all 4 tests passed.