Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #729
Summary of Changes
When building
libvncserver.so, internal bundled TurboJPEG functions (tjCompress,tjCompress2,tjInitCompress, etc.) were exported into the global symbol table becauseDLLEXPORTinsrc/common/turbojpeg.hdefaulted to empty (public export) on GCC/Clang ELF systems.This PR updates
DLLEXPORTmacro definition insrc/common/turbojpeg.hto set__attribute__ ((visibility ("hidden")))when compiling with GCC/Clang (version >= 4), ensuring bundled TurboJPEG functions remain private tolibvncserverand do not override global symbols when applications link against bothlibvncserverand systemlibjpeg-turbo.Added automated runtime symbol visibility test check in
test/cargstest.cviadlsymto prevent regressions.