Repository navigation
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
| char command[1024]; | ||
| snprintf(command, sizeof(command), "readelf -Ws %s | grep -E \" [A-Z]+ +GLOBAL +DEFAULT +[0-9]+ +tj\"", argv[1]); | ||
| int status = system(command); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #729
Root Cause
When building libvncserver with bundled turbojpeg implementation (), in evaluated to empty string under GCC/Clang on Unix/Linux systems, causing GCC to export all symbols (, , , etc.) as global dynamic symbols in . Applications linking both and system would inadvertently bind calls to 's internal implementation.
Fix
Defined as for GCC compilers so internal symbols remain local/hidden within . Added a test in ensuring symbols are not exported.