Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour. 📝 WalkthroughWalkthroughThe ChangesModule dependency update
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Other Merge Risk: ⚪ Minimal · up to The updated dependencies resolve together and their checksums verify. No concrete merge-blocking issue is evident; normal build and CI checks remain. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
CI result for exact commit
Keep this PR open. Do not treat the passing affected-path tests as green CI or full security coverage. Verify the combined tree and required CI after #473 lands; the upstream Azure stack and real-scenario acceptance also remain open. |
Why
The platform still resolves the older Azure commitments module. This PR updates the Azure provider pin, the shared
pkgpin required by the new Azure module, and their Go-generated checksums. AWS and GCP pins stay unchanged.Evidence
pkgmodule versions were fetched through Go's public module proxy and authenticated by Go checksums. Offline module inspection selected Azurev0.0.0-20261004143708-56555e1be095andpkgv0.0.0-20260929105827-b3b4cb5e3d80; AWS and GCP stayed atce9513612901.Manager.executeSinglePurchasewith a concrete Azure compute client, fake credential, synthetic HTTP responses, and mocked platform dependencies. With the old Azure module, monthly and upfront assertions failed on both initial purchase and matching-order re-drive: purchase history stored2000and logs printedcost=2000.00. With the new module, all four cases passed. Monthly stored a non-nil zero and loggedcost=0.00; upfront stored nil and loggedcost=unknown. The plan'stotalUpfrontstill reads the recommendation's planned upfront cost.-race -shortininternal/purchaseandinternal/scheduler. A separate loopback managed-identity fixture confirmed the scheduler's all-accounts-fail error path without ambient credentials or a cloud request. The server command built to a scratch output, andgo mod tidy -diffwas clean after the required directpkgpin update.tests/e2emodules, file checks, git-secrets, and Trivy. Hooks without matching manifest files were skipped normally.gpt-6-astrareview of exact commit369728d5ecaa45cc9191bcd8d59c8f35b2757056found no actionable issue in the full effective Azure andpkgsource delta from the older published versions. The reviewer independently reran all four synthetic concrete-client cases under-race; monthly and upfront initial purchases and matching-order re-drives passed. The raw replay log is/tmp/claude/go76-platform-azure-astra-replay-v1.log(SHA256829b57e16a76edc965c18c460b57f2f2821913e8dd63d6905f5fa7300775f400).The tests use synthetic Azure responses and local fixtures. They do not establish live Azure catalog availability, a real reservation purchase, or end-user acceptance. PR-triggered Linux CI still needs to run.
Dependency and scope
This PR depends on the still-open Azure pricing stack PR #187 and its ancestors. Keep this consumer PR open until the upstream stack and real-scenario acceptance are complete. The independent upstream review covered the
9962786to56555e1delta, and the consumer review covered the full effectivece951to56555e1Azure andpkgsource delta. Real-scenario acceptance remains unproved. This dependency update is not the full fix for cloud-commitments-go #76 or #132. Both issues remain open. Refs LeanerCloud/cloud-commitments-go#76 and LeanerCloud/cloud-commitments-go#132.Summary by CodeRabbit