Repository navigation
test(azure): stub server pagers in Azure SQL converter tests - #257
Merged
Merged
Conversation
Three converter tests stubbed only capabilities, so convertAzureSQLRecommendation walked the default ARM pagers and sent real GETs to management.azure.com. Inject empty managed-instance and server pagers so none can reach a live client.
Contributor
|
Warning Review limit reached
This review includes 2 billable files and costs up to $0.50.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 5 minutes for your next included review. View limit detailsLimit details: You’ve used the included review currently available. Your 64 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (2)
Comment |
Route the SDK's own transport through a counting loopback proxy installed in TestMain and assert the converter scenarios make zero external requests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #184
Three converter tests (PopulatesAllFields, PopulatesEngineVersion, CapabilitiesErrorFallsBack) stubbed only capabilities. convertAzureSQLRecommendation reaches fetchServerInfo, which built default ARM pagers and issued real GETs to management.azure.com (a 400 InvalidSubscriptionId came back in the test log).
Fix: inject empty managed-instance and server pagers in those three tests.
Verification: before,
go test -short -von the package logged 3 management.azure.com requests; after, 0. Removing the pagers from one test again produced 1. No loud-failure guard added: the package has no existing network-denial pattern and the issue's suggested one would be a new abstraction.