fix(azure): cap and cancel-check the eight remaining pager loops

[cristim]

What

Adds the page cap and ctx.Err() check the sibling loops already use to the eight pager loops listed in #93:

• cache fetchSKUCatalogue (cap maxCachesPages)
• cosmosdb fetchDominantAPIType (cap maxAccountsPages)
• database walkManagedInstances and hasRegularServers (new maxSQLListPages = 20)
• managedredis GetExistingCommitments (new maxReservationsPages = 50)
• synapse GetRecommendations and collectSynapseReservations (new maxRecsPages, maxReservationsPages)
• compute collectExchangeableReservations (existing maxReservationsPages)

Behaviour change

• Loops that already returned errors (managedredis, synapse, exchange) now return a cap error or the wrapped context error instead of walking on. The exchange ownership listing no longer spins on an endless pager.
• Four loops log and return a degraded value by design (SKU catalogue, Cosmos API type, SQL walks). They keep that contract: on cap or cancel they log (cap case names the service and cap) and return the same failure value as a page error; walkManagedInstances returns complete=false, as in fix(azure): leave AZConfig and Deployment empty on a managed-instance page error #240.

How verified

Fake pagers report More() for 1000 pages. Each loop has a cap test (calls stop at the cap) and a cancelled-context test (zero NextPage calls). Normal multi-page behaviour stays covered by the existing tests. Pre-fix the compute tests fail ("An error is expected but got nil", cancel error nil); removing the cap in the cosmosdb loop fails its test (expected 20, actual 1000). go vet ./..., go test ./... and golangci-lint run ./... pass in providers/azure (exit 0).

hasRegularServers now returns (found, complete); fetchServerInfo blanks AZConfig and Deployment when the server walk is incomplete (cap, cancel, page error), so an incomplete walk no longer reads as "no servers" and yields Deployment "managed".

Follow-ups (not in this PR)

Loops with the same shape: managedredis/client.go ~427 (collectSKUsFromPager), savingsplans/client.go ~155, provider.go ~478 (locations), accounts_cache.go ~212 (subscriptions), recommendations.go ~345 (Advisor), plus the two loops in #103. serverInfoOnce caching a cancelled first fetch is pre-existing and tracked in #241.

Closes #93

[cristim]

@coderabbitai full review

[coderabbitai]

Warning

Review limit reached

• Run on-demand review

_{This review includes 12 billable files and costs up to $3.00.}

• Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 13 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 61 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

• Configuration used: Repository: LeanerCloud/cloud-commitments-go/.coderabbit.yaml
• Review profile: CHILL
• Plan: Essentials
• Run ID: c94cf744-ff88-473d-873a-339d3a4ddd55

📥 Commits

Reviewing files that changed from the base of the PR and between 4a7fac7 and 24caa60.

📒 Files selected for processing (12)

• providers/azure/services/cache/client.go
• providers/azure/services/cache/pagination_cap_test.go
• providers/azure/services/compute/exchange.go
• providers/azure/services/compute/exchange_pagination_cap_test.go
• providers/azure/services/cosmosdb/client.go
• providers/azure/services/cosmosdb/pagination_cap_test.go
• providers/azure/services/database/client.go
• providers/azure/services/database/pagination_cap_test.go
• providers/azure/services/managedredis/client.go
• providers/azure/services/managedredis/pagination_cap_test.go
• providers/azure/services/synapse/client.go
• providers/azure/services/synapse/pagination_cap_test.go

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

⚠️ Action not completed

Review rate limited.

---

Your included review limit is currently reached under our Fair Usage Limits Policy. Your current included review allowance is based on your included PR review attempts over the past 7 days. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 25 minutes.