Repository navigation
Sort Local Files folder and track names case-insensitively - #906
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
LargeModGames
left a comment
There was a problem hiding this comment.
Please add a Fixed line under ## [Unreleased] in CHANGELOG.md for the new sort order. The code and tests match the issue, so I'll merge after that.
Both sorts compared names by raw byte order, so every capital letter sorted before every lowercase one and mixed-case libraries looked unsorted. The folder list and the name fallback for untagged tracks now compare lowercased names, with byte order as a stable tiebreak. Fixes LargeModGames#824
016c7fa to
3b0607d
Compare
|
Added a Fixed line under Unreleased, commit 3b0607d. |
The Local Files source sorted folder names and the name fallback for untagged tracks by raw byte order, so every capital letter came before every lowercase one:
abba/,Beatles/andZappa/listed as Beatles, Zappa, abba, and an untaggedTrack.mp3sorted beforeanother.mp3.Both sorts now compare lowercased names, with the original byte order as a stable tiebreak so two names that differ only in case keep a deterministic order. The
(root)entry stays first,subdirs.sort()incollect_audio_dirsis untouched (it only decides walk order), andrelative_display_nameis not changed, so this does not overlap with #621 beyond touching the same file.Fixes #824
Summary by CodeRabbit