Fixed 2x2 live-run dashboard, visible run timer, START/STOP gating - #185
Merged
Merged
Conversation
…P on the run The dashboard's Run Control panel hid its timer while running, expecting the banner, but DashboardView hides the banner while that panel is on screen. START also stayed enabled mid-run and neither button had a disabled style, so START always looked green and STOP always grey. START now enables only when ready and idle, STOP only mid-run, and both dim when disabled.
Camera Feed | Device States & Timer / Start, Stop, Metadata | Manual Control. - DashboardView is now a fixed equal grid with a run header (timer, state pill, REC) atop the device states; RunControlPanel keeps the run clock and feeds the header via elapsed_updated, so the timer shows in every state. - RunControlPanel gains editable name/experimenter/protocol/notes bound to session.metadata (read-only while live), file actions, the readiness status line and the housekeeping menu, replacing the Experiment Info panel. - Remove the swappable quadrant machinery: QuadrantHost, layout model and persistence (dashboard_layout.json), panel registry, the dashboard's RunBanner wiring, and their tests. - The dashboard's HardwarePanel stays built but hidden: it backs Connect / Ports and the hardware-change refresh fan-out.
…view A filled field hides its placeholder, so experimenter and protocol values read as unlabelled text; each field now has a caption. The file-action row sits above the metadata so it never scrolls off a short quadrant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the swappable dashboard with the fixed live-run layout the user asked for, and fixes the Run Control timer disappearing during a run.
Layout (fixed, equal quadrants)
session.metadata, mark the session dirty, and lock while RUNNING/PAUSED.RunControlPanel. The header only shows the text it emits throughelapsed_updated, so the time text has a single source.quadrant_host.py,layout.py,layout_store.py,panel_registry.py,experiment_info_panel.pyand their tests, along with the picker/drag-swap code,dashboard_layout.jsonpersistence and the dashboard's run banner.RunBanneritself stays for the runner-mode shell, which is unchanged.HardwarePanelis still built but hidden. It backs the Connect / Ports dialog and the hardware-change refresh.Bug fixes
DashboardViewhid the banner whenever Run Control was on screen.desktop.qssandtouch.qss. The Run tab (runner_panel.py) got the same gating.Tests
mainbecause the removed layout system's tests are gone. ruff and black are clean.