Show live PWM values and allow runs with no board - #184
Merged
Merged
Conversation
Both device-state panels only read _state, which digital outputs have but PWM outputs (_value) and servos (_angle) do not, so those cards never changed during a run. The display logic now lives once in device_status.device_state_display: PWM shows its duty cycle, servos their angle, and analog inputs scale by the board's real ADC resolution.
Readiness required a connected board even when the session had none to
connect, so a video-only experiment could never start. A session with no
boards is now board-ready ("None needed"); the core already starts such a
run cleanly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two runner fixes reported from the rig.
_state. PWM outputs keep their level in_valueand servos in_angle, so their cards stayed frozen while digital outputs updated. The four copies of the display logic are now one helper,device_status.device_state_display. PWM shows its duty cycle as a percentage and servos show their angle. Analog inputs now scale by the board's actual ADC resolution instead of a hardcoded 1023.Full suite: 5818 passed, 4 skipped. ruff and black are clean.