Repository navigation
test(middleware): cover loan access tenant boundaries, multi-role matrix, and parameter guards - #2220
Open
GangDev6707 wants to merge 1 commit into
Open
GangDev6707 wants to merge 1 commit into
GangDev6707 wants to merge 1 commit into
Conversation
…rix, and parameter guards
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds comprehensive unit and regression test coverage for
loanAccessmiddleware inbackend/src/middleware/__tests__/loanAccess.test.ts, addressing cross-account tenant isolation between borrowers, multi-role access contracts, and parameter validation guards.Closes #2092
Details of Changes
requireLoanBorrowerAccessorrequireLoanOwner, and vice-versa), asserting 403AppErrorwithErrorCode.ACCESS_DENIED.borrower,investor,guest,auditor, or undefined role) are rejected with 403ACCESS_DENIEDwhen the caller public key does not match the stored borrower address.requireLoanBorrowerAccess:adminorlenderroles can inspect loan details without executing database queries (next()called immediately).requireLoanOwner:requireLoanOwnerstrictly enforces loan ownership without role bypasses (rejectingadminorlendercallers if they are not the recorded loan owner).loanIdparameter in both middlewares, asserting 400 Bad Request withLoan ID is required.Verification & CI Proof
npm run lint: Passed (0 errors)npm run build: Passed (0 errors)npm test -- src/middleware/__tests__/loanAccess.test.ts: 31/31 tests passing (100% green)