Repository navigation
test(notifications): cover route pagination, read filters, and deleted records - #2217
Open
ranjan1969x wants to merge 1 commit into
Open
ranjan1969x wants to merge 1 commit into
ranjan1969x wants to merge 1 commit into
Conversation
Malware detection scan flagged this pull requestThe scan found 1 indicator(s) in the PR diff. This PR is blocked until a maintainer reviews the flagged files.
This is an automated triage signal; maintainers must verify whether the finding is malicious or intentional. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds comprehensive unit and integration tests for
GET /api/notificationsandPOST /api/notifications/mark-readcovering stable pagination, read and status filter semantics, deleted and purged record handling, and multi-tenant authorization boundaries.Closes #2099
Key Test Coverage Added
limitquery parameter is omitted.limit=1(minimum allowed) andlimit=100(maximum allowed).ORDER BY created_at DESCnewest-first chronological sorting across items.limit=0, negative limits,limit=101, non-numeric strings) with 400 Bad Request.status=unread,status=read, andstatus=archived.read: booleanandstatus: stringremain synchronized (read: falsefor unread,read: truefor read/archived).unreadCountaccurately reports total active unread count regardless of activestatus=readfilter.POST /api/notifications/mark-readhandles non-existent or previously-deleted IDs gracefully.{ ids: [] }.read:notificationsscope (such as lender role) with 403 Forbidden.user_id =isolation so users can never read or mark each other's notifications.Verification
npm test -- src/__tests__/notificationPagination.test.ts(22/22 tests passing, 100% green)npm run build(0 TypeScript compilation errors)