Colour profile option, scrollable presets list, quiet offline update check (1.2.3) - #25
Merged
Merged
Conversation
…its own, stay quiet offline - Presets get "Keep colour profile (ICC)". Removing metadata used to drop the ICC profile too, which makes wide-gamut photos (Display P3 from phones) look washed out; now the profile stays unless this is turned off. The option is enabled while metadata is removed, and shown ticked while all metadata is kept. - The presets page fits the window: the preset list and the editor scroll separately, and Save/Revert stay visible below the editor. - The update check also treats a connection that breaks while reading as "offline" (it could end the app from the periodic check); tests cover no network, timeout, a dropped connection and a non-JSON answer. Version 1.2.3. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
IOExceptionfrom the periodic check could end the app). New tests: no network, timeout, dropped connection, non-JSON answer.Tests
App tests 147 passed (4 new offline cases);
ImageAndPdfTests21 passed (3 new metadata/colour profile cases). Presets page rendered and checked (page-presets-en.png).🤖 Generated with Claude Code