Repository navigation
Fix disabled FIFO latest ready mode in swapchain recreation - #1587
Merged
marty-johnson59 merged 1 commit intoOct 19, 2026
Merged
marty-johnson59 merged 1 commit into
marty-johnson59 merged 1 commit into
Conversation
| modes.pPresentModes = compatible_modes.data(); | ||
| VK_CHECK(vkGetPhysicalDeviceSurfaceCapabilities2KHR(get_gpu_handle(), &surface_info, &surface_caps)); | ||
|
|
||
| if (!get_device().is_extension_enabled( |
Contributor
There was a problem hiding this comment.
I think, you should add some in-code comment why you're removing something from the driver's answer here.
Contributor
Author
There was a problem hiding this comment.
Added comment that explains why we're removing it.
Remove VK_PRESENT_MODE_FIFO_LATEST_READY_EXT from compatible present modes when its required device extension is not enabled, preventing a validation error during swapchain creation. Fixes KhronosGroup#1360
eraycep
force-pushed
the
fix-swapchain-recreation-validation
branch
from
October 12, 2026 12:56
3ca0058 to
dc98571
Compare
asuessenbach
approved these changes
Oct 13, 2026
SaschaWillems
approved these changes
Oct 13, 2026
tomek-brcm
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Filter out
VK_PRESENT_MODE_FIFO_LATEST_READY_EXTwhen its required device extension is not enabled, preventing a validation error during swapchain creation.Tested on Linux with AMD Radeon Graphics (RADV RENOIR).
The sample builds, and filtering was verified using a temporarily
injected present mode; the test code was removed afterward.
The driver does not advertise the required extension, so the original
failure could not be reproduced directly. Existing image-count and
swapchain-destruction validation errors also occur without this patch.
Windows, macOS, and Android builds have not been tested.
Fixes #1360
General Checklist:
Please ensure the following points are checked:
Note: The Samples CI runs a number of checks including:
If this PR contains framework changes:
batchcommand line argument to make sure all samples still work properlySample Checklist
If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist: