Skip to content

Fix disabled FIFO latest ready mode in swapchain recreation - #1587

Merged
marty-johnson59 merged 1 commit into
KhronosGroup:mainfrom
eraycep:fix-swapchain-recreation-validation
Oct 19, 2026
Merged

marty-johnson59 merged 1 commit into
KhronosGroup:mainfrom
eraycep:fix-swapchain-recreation-validation

Conversation

@eraycep

@eraycep eraycep commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Description

Filter out VK_PRESENT_MODE_FIFO_LATEST_READY_EXT when its required device extension is not enabled, preventing a validation error during swapchain creation.

Tested on Linux with AMD Radeon Graphics (RADV RENOIR).
The sample builds, and filtering was verified using a temporarily
injected present mode; the test code was removed afterward.

The driver does not advertise the required extension, so the original
failure could not be reproduced directly. Existing image-count and
swapchain-destruction validation errors also occur without this patch.

Windows, macOS, and Android builds have not been tested.

Fixes #1360

General Checklist:

Please ensure the following points are checked:

  • My code follows the coding style
  • I have reviewed file licenses
  • I have commented any added functions (in line with Doxygen)
  • I have commented any code that could be hard to understand
  • My changes do not add any new compiler warnings
  • My changes do not add any new validation layer errors or warnings
  • I have used existing framework/helper functions where possible
  • My changes do not add any regressions
  • I have tested every sample to ensure everything runs correctly
  • This PR describes the scope and expected impact of the changes I am making

Note: The Samples CI runs a number of checks including:

  • I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
  • My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

If this PR contains framework changes:

  • I did a full batch run using the batch command line argument to make sure all samples still work properly

Sample Checklist

If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist:

  • I have tested the sample on at least one compliant Vulkan implementation
  • If the sample is vendor-specific, I have tagged it appropriately
  • I have stated on what implementation the sample has been tested so that others can test on different implementations and platforms
  • Any dependent assets have been merged and published in downstream modules
  • For new samples, I have added a paragraph with a summary to the appropriate chapter in the readme of the folder that the sample belongs to e.g. api samples readme
  • For new samples, I have added a tutorial README.md file to guide users through what they need to know to implement code using this feature. For example, see conditional_rendering
  • For new samples, I have added a link to the Antora navigation so that the sample will be listed at the Vulkan documentation site

@CLAassistant

CLAassistant commented Oct 7, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

modes.pPresentModes = compatible_modes.data();
VK_CHECK(vkGetPhysicalDeviceSurfaceCapabilities2KHR(get_gpu_handle(), &surface_info, &surface_caps));

if (!get_device().is_extension_enabled(

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, you should add some in-code comment why you're removing something from the driver's answer here.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comment that explains why we're removing it.

Remove VK_PRESENT_MODE_FIFO_LATEST_READY_EXT from compatible present
modes when its required device extension is not enabled, preventing
a validation error during swapchain creation.

Fixes KhronosGroup#1360
@eraycep
eraycep force-pushed the fix-swapchain-recreation-validation branch from 3ca0058 to dc98571 Compare October 12, 2026 12:56
@marty-johnson59
marty-johnson59 merged commit 47e46df into KhronosGroup:main Oct 19, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Validation error in swapchain recreation example if VK_EXT_present_mode_fifo_latest_ready is supported but not enabled

6 participants