Fix completeness check - #3990
Merged
Merged
Conversation
unp1
force-pushed
the
fixCompletenessCheck
branch
from
October 2, 2026 11:42
4ab5b99 to
4758927
Compare
Skolem constants are now first created upon execution of the taclet (not at match time) Hence, a taclet app queried for "complete" returns false for skolem constants, instead completeExceptSkolemConstants must be used.
unp1
force-pushed
the
fixCompletenessCheck
branch
from
October 2, 2026 11:44
4758927 to
a291b86
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A previous PR moved the creation of Skolem constants to a later point such that they are now first created upon execution of the taclet and not at match time. This avoids premature reservation of names.
Hence, a taclet app queried for "complete" returns false for skolem constants, instead
completeExceptSkolemConstants must be used. This avoids an unnecessary MatchDialog appearance when applying skolemization rules.
Intended Change
Check completeness with completeExceptSkolemConstants when deciding whether a taclet can be applied. Use "complete" only after creation of the Skolem constants.
Type of pull request
Ensuring quality
Additional information and contact(s)
The contributions within this pull request are licensed under GPLv2 and later for inclusion in KeY.