Repository navigation
[Issue #154] T1 lane set: one qualified independent review (v2.1.3 P3) - #156
Merged
Merged
Conversation
…or a declared acceptance check (v2.1.3 P3) Add the Qualified review for T1 gate to external-review.md (qualification list, provider-state outcome table, multi-source required reviewers, ignored-source triage), make the T1 lane set tier-aware in phase3.5/phase4/contract/template, retire the P2 interim wording, and add validator pins plus a multi-source Required reviewers parser with tests. Co-Authored-By: Claude Sonnet <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (8 files)
Reviewed by nemotron-3.5-super-vl:free · Input: 199.3K · Output: 26K · Cached: 516K Review guidance: REVIEW.md from base branch |
KHAEntertainment
added a commit
that referenced
this pull request
Oct 26, 2026
Conflicts in scripts/validate_skill.py and tests/test_backend_contract.py resolved by keeping both sides: P3's check_t1_lane_set and T1LaneSetTests, and P6's check_evidence_profile and EvidenceProfileTests. Co-Authored-By: Claude Opus <noreply@anthropic.com>
This was referenced Oct 26, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #154
Rationale
v2.1.3 P3. T1 now runs one qualified independent review, and the QA (acceptance) lane only when a declared acceptance check applies. The P2 interim ("T1 keeps the current lanes") is retired. T2/T3 are unchanged.
What changed
external-review.md: new Qualified review for T1 section (qualification list, provider-state outcome table, multi-source required reviewers, ignored-source triage); intro and Modeoffwording adjusted. Shipped breakpoint/substitution rule and Kilo head-bound summary rule untouched.phase3.5.md: P2 interim sentence replaced by the T1 QA rule; QA-lane section scoped to when the lane runs.phase4.md(Pre-Review Preparation dispatch text, Review Rating only): internal reviewer dispatched for T1 only per the new section.backends/contract.md: "Worker → PR → QA → Review is unchanged" replaced by a tier-aware invariant; distinct-ID/read-only invariants kept ("When they run").PROJECT_CONTEXT_TEMPLATE.md: Required reviewers guidance: one qualified independent source by default; more than one only when policy requires, each trusted and mapped.SKILL.md: Phase 3.5 core-principle line only.validate_skill.py:check_t1_lane_set,parse_required_reviewers,check_required_reviewer_policy(accepts multi-source); the Kilo pin is now list membership instead of the exact line.tests/test_backend_contract.py: newT1LaneSetTests; one stale pin updated.internal_review_status: not_dispatched, source incompleted_reviewers, governing requirement inexpected_reviewers.Acceptance criteria
Focused checks (run at head cf43453)
python3 scripts/validate_skill.py→OK: validated …/skills/dev(exit 0)python3 -m unittest tests.test_backend_contract→Ran 143 tests … OK(exit 0)python3 -m unittest tests.test_validate_skill tests.test_skill_frontmatter→Ran 61 tests … OK(exit 0)python3 -m py_compile scripts/validate_skill.py tests/test_backend_contract.py→ exit 0Coverage-path audit
Changed paths: tier table consumers (SKILL.md router ↔ phase3.5, still agreeing; RiskTierTests pass),
check_t1_lane_set(live + 7 drift mutations fail),check_required_reviewer_policy(6 valid, 5 invalid fixtures), Kilo pin (membership). No inspector change (--required-revieweralready repeats).Caller impact
Docs/validator only.
PROJECT_CONTEXT.mdnot edited (itsRequired reviewers: kilostill validates). Graft: installed, repo not indexed →graph_evidence: unavailable; callers checked withrg.🤖 Generated with Claude Code