Repository navigation
[Fix]clear exhaustion with /feed - #406
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restores the "clear exhaustion" behavior of
/feed, which was lost when Minecraft removedFoodData#setExhaustion.Fixes #306
Problem
Newer Minecraft versions no longer expose a setter for exhaustion on
FoodData; it can only be added to through the public API.FeedCommandhad thesetExhaustion(0)call commented out, so/feedrestored food level and saturation but left any accumulated exhaustion in place.Changes
mixin/FoodDataAccessor.java(new): an@Accessormixin that exposes a setter for the privateexhaustionLevelfield ofFoodData.essential_commands.mixins.json: registersFoodDataAccessor.FeedCommand.java: calls the accessor to reset exhaustion to0after setting food level and saturation, and removes the old commented-out line.Testing
./gradlew buildsucceedsdefaultRequireis 1)/feedon a player with low food and accumulated exhaustion restores food and saturation, and exhaustion no longer carries overNotes
The accessor targets the Mojang-mapped field name
exhaustionLevel. I couldn't verify it against the target Minecraft version in my environment, so please confirm it during testing.