Skip to content

docs(repo): second whole-repo pass over repo-level files (#1103) - #1804

Merged
JarryShaw merged 1 commit into
mainfrom
docs/1103b-repo
Oct 15, 2026
Merged

JarryShaw merged 1 commit into
mainfrom
docs/1103b-repo

Conversation

@JarryShaw

Copy link
Copy Markdown
Owner

Please follow the guide below

What is the purpose of your pull request?

Tick the commit type your subject line carries.

  • fix — corrects a defect
  • feat — adds a feature
  • perf — changes performance, not behaviour
  • refactor — changes neither behaviour nor performance
  • test — tests only
  • docs — documentation only
  • ci — workflows or build tooling
  • release — bumps the version or rolls up a distribution
  • chore — anything else

Summary

#1103 second whole-repo pass, repo slice.

Accuracy -- claims that no longer matched the tree:

  • Six crawlers import bs4 at module scope, not seven (pyproject x2,
    cron-vendor.yml); cron-vendor installs .[all,vendor], not .[all].
  • benchmark: a default run spawns 3,000 tshark processes per environment,
    not six thousand (README, benchmark.py).
  • options.py: IPv4 and HIP have registries; make_samples.py: in.pcap and
    dhcp.pcapng are tracked; the PyYAML note no longer lists four of eleven.
  • Re-measured: ci-timing calls (690) and workflow list, bump_version's
    version-commit counts, verdict_covers_checkout's bot commits, and
    MANIFEST.in's sdist note (no stale entry count or "four lines").
  • Stale line references: raw.py, arp.py, engines/pcapng.py, pyproject.toml.

Citations: PR #434 and PR #853 cited as their issues, #429 and #851.

Timed context: about 20 "now", "since #NNN", "no longer", "as before",
"until #1674" and "lately" phrases across the workflows, util/ and examples/.

Comments and docstrings only: every changed .py keeps an identical AST with
string expressions blanked; YAML and TOML load identically, except comment-only
lines in one cron-vendor.yml run: block. tests/project passes.

Refs #1103

Accuracy -- claims that no longer matched the tree:
- Six crawlers import bs4 at module scope, not seven (pyproject x2,
  cron-vendor.yml); cron-vendor installs .[all,vendor], not .[all].
- benchmark: a default run spawns 3,000 tshark processes per environment,
  not six thousand (README, benchmark.py).
- options.py: IPv4 and HIP have registries; make_samples.py: in.pcap and
  dhcp.pcapng are tracked; the PyYAML note no longer lists four of eleven.
- Re-measured: ci-timing calls (690) and workflow list, bump_version's
  version-commit counts, verdict_covers_checkout's bot commits, and
  MANIFEST.in's sdist note (no stale entry count or "four lines").
- Stale line references: raw.py, arp.py, engines/pcapng.py, pyproject.toml.

Citations: PR #434 and PR #853 cited as their issues, #429 and #851.

Timed context: about 20 "now", "since #NNN", "no longer", "as before",
"until #1674" and "lately" phrases across the workflows, util/ and examples/.

Comments and docstrings only: every changed .py keeps an identical AST with
string expressions blanked; YAML and TOML load identically, except comment-only
lines in one cron-vendor.yml run: block. tests/project passes.

Refs #1103
@JarryShaw JarryShaw added the docs Pull requests that change documentation only (docs: subject prefix) label Oct 15, 2026
@JarryShaw

Copy link
Copy Markdown
Owner Author

Verdict: GOOD TO GO at 7f357aa01. A Sonnet cross-review (author: Opus) found no blocking findings. Scope stays inside the slice, the AST guard is identical against main, and every directive was checked against the release tags. The merged build of all nine second-pass heads has 18 warnings, the same as main. tests/project: 950 passed, 1 skipped, 3 warnings, 3670 subtests passed.

@JarryShaw JarryShaw added the review: good-to-go Cross-review at the current head says ready; CI state is separate label Oct 15, 2026
@JarryShaw
JarryShaw merged commit 1764d1d into main Oct 15, 2026
13 checks passed
@JarryShaw
JarryShaw deleted the docs/1103b-repo branch October 15, 2026 23:42
@JarryShaw JarryShaw removed the review: good-to-go Cross-review at the current head says ready; CI state is separate label Oct 15, 2026
@JarryShaw JarryShaw moved this to Done in PyPCAPKit Oct 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Pull requests that change documentation only (docs: subject prefix)

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant