Repository navigation
docs(repo): second whole-repo pass over repo-level files (#1103) - #1804
Merged
Merged
Conversation
Accuracy -- claims that no longer matched the tree: - Six crawlers import bs4 at module scope, not seven (pyproject x2, cron-vendor.yml); cron-vendor installs .[all,vendor], not .[all]. - benchmark: a default run spawns 3,000 tshark processes per environment, not six thousand (README, benchmark.py). - options.py: IPv4 and HIP have registries; make_samples.py: in.pcap and dhcp.pcapng are tracked; the PyYAML note no longer lists four of eleven. - Re-measured: ci-timing calls (690) and workflow list, bump_version's version-commit counts, verdict_covers_checkout's bot commits, and MANIFEST.in's sdist note (no stale entry count or "four lines"). - Stale line references: raw.py, arp.py, engines/pcapng.py, pyproject.toml. Citations: PR #434 and PR #853 cited as their issues, #429 and #851. Timed context: about 20 "now", "since #NNN", "no longer", "as before", "until #1674" and "lately" phrases across the workflows, util/ and examples/. Comments and docstrings only: every changed .py keeps an identical AST with string expressions blanked; YAML and TOML load identically, except comment-only lines in one cron-vendor.yml run: block. tests/project passes. Refs #1103
Owner
Author
|
Verdict: GOOD TO GO at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
You will be asked some questions, please read them carefully and answer honestly
Put an
xinto all the boxes [ ] relevant to your pull request (like that [x])Use Preview tab to see how your pull request will actually look like
Searched for similar pull requests
Followed the coding style (
make pylint,make mypy,make isort)make testpasses, and a test case covers the change. Narrow runs only, listed below.Added a changelog entry under
docs/source/changelog/and regeneratedCHANGELOG.md, if the change is user-visible: N/A — centralised in docs(changelog): shared 1.5.0 changelog — long-lived, merges last (#610, #616, #617, #618, #620) #657What is the purpose of your pull request?
Tick the commit type your subject line carries.
fix— corrects a defectfeat— adds a featureperf— changes performance, not behaviourrefactor— changes neither behaviour nor performancetest— tests onlydocs— documentation onlyci— workflows or build toolingrelease— bumps the version or rolls up a distributionchore— anything elseSummary
#1103 second whole-repo pass, repo slice.
Accuracy -- claims that no longer matched the tree:
cron-vendor.yml); cron-vendor installs .[all,vendor], not .[all].
not six thousand (README, benchmark.py).
dhcp.pcapng are tracked; the PyYAML note no longer lists four of eleven.
version-commit counts, verdict_covers_checkout's bot commits, and
MANIFEST.in's sdist note (no stale entry count or "four lines").
Citations: PR #434 and PR #853 cited as their issues, #429 and #851.
Timed context: about 20 "now", "since #NNN", "no longer", "as before",
"until #1674" and "lately" phrases across the workflows, util/ and examples/.
Comments and docstrings only: every changed .py keeps an identical AST with
string expressions blanked; YAML and TOML load identically, except comment-only
lines in one cron-vendor.yml run: block. tests/project passes.
Refs #1103