Skip to content

const/vendor: drop version directives from the generated tables and their templates #1884

Closed

Description

@JarryShaw

The owner ruled on #1872 that the vendor templates under pcapkit/vendor/** and the generated pcapkit/const/** files take no versionadded/versionchanged directives, because the scripts regenerate them.

Several templates on main still carry them, each mirrored in its const file:

  • ftp/command
  • http/method
  • ipv6/extension_header
  • pcapng/option_type
  • pcapng/tls_key_label
  • reg/apptype/apptype
  • tcp/flags

Find them with git grep -n -E 'version(added|changed|removed)' -- pcapkit/vendor pcapkit/const.

Fix: remove each directive from the template and from the generated file identically, without re-crawling, and update any test that pins the text. Where a directive records a change users need to know about, move the note to the hand-written docs/source/pcapkit/const/*.rst page, as #1872 does. Keep the #: notes on MAX_RETRY and the CI-mode flag in pcapkit/vendor/default.py: they document the crawler framework's own settings, not a template.

Blocked until #1871 merges, because it edits pcapkit/vendor/reg/apptype/apptype.py.

Activity

  1. added
    docsPull requests that change documentation only (docs: subject prefix)
    constRegenerated IANA or vendor constant tables; members keep their numeric values
    blockedDeferred pending another issue or decision; see the last comment for what unblocks it
    on Oct 17, 2026
  2. moved this to Blocked in PyPCAPKiton Oct 17, 2026
  3. JarryShaw commented on Oct 17, 2026

    @JarryShaw
    OwnerAuthor

    Unblocked: #1871 merged, so the reg/apptype/apptype template is free to edit. A worker is on it.

  4. added
    wipWork in flight - a covering PR is open or an agent is actively on it
    and removed
    blockedDeferred pending another issue or decision; see the last comment for what unblocks it
    on Oct 17, 2026
  5. moved this from Blocked to WIP in PyPCAPKiton Oct 17, 2026
  6. removed
    wipWork in flight - a covering PR is open or an agent is actively on it
    on Oct 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    constRegenerated IANA or vendor constant tables; members keep their numeric valuesdocsPull requests that change documentation only (docs: subject prefix)

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions