Skip to content

Build ioda and ioda-converters with Python 3.13 - #2117

Merged
climbfuji merged 2 commits into
JCSDA:developfrom
climbfuji:bugfix/ioda_iodaconv_py313
Sep 11, 2026
Merged

Build ioda and ioda-converters with Python 3.13#2117
climbfuji merged 2 commits into
JCSDA:developfrom
climbfuji:bugfix/ioda_iodaconv_py313

Conversation

@climbfuji

@climbfuji climbfuji commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

Description

Relax constraint on python in ioda, patch ioda-converters so that it builds and passes the ctests with python@3.13, py-numpy@2.1.4, and py-pandas@2.3.3. See #2116 for the glorious details.

This pull request is necessary to move forward with the update to python@3.13 for spack-stack release 2.2. It ensures that the answers of ioda-converters don't change when updating from py-numpy@1.26.4 to py-numpy@2.1.4.

@mathomp4 @eap Please note that py-pandas must remain at version 2; the latest available version 2.3.3 works.

Dependencies

None

Issues addressed

Closes #2116
Working toward #887

Applications affected

JEDI components installed in spack-stack environments

Systems affected

None

Testing

  • CI: Note whether the automatic tests (GitHub actions tests that run automatically for every commit) pass or not
    • GitHub actions CI tests pass
    • GitHub actions CI tests do not pass (provide explanation)
    • GitHub actions CI tests skipped (provide explanation if necessary)
  • New tests added: List and describe any new tests added to GitHub actions
    • ...
  • Additional testing: Add information on any additional tests conducted
    • Built oops, ioda, ioda-converters, ropp-ufo, and ufo versions as currently in spack-stack with gcc@14.2.1, python@3.13, py-numpy@2.1.4, and py-pandas@2.3.3. The ctests all passed for each of these packages, except the ones explicitly included in the package recipes.

Checklist

  • This PR addresses one issue/problem/enhancement or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.
  • All necessary updates to the documentation (spack-stack wiki) will be made when this PR is merged

…lds and passes the ctests with python@3.13, py-numpy@2.1.4, and py-pandas@2.3.3

@srherbener srherbener left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The extensive patches to the ioda-converters python scripts seem, in general, updates that should be applied in the ioda-converters repo. I've had success in telling Claude to provide instructions for another Claude session to implement fixes. Ie, the session that created the patches for spack-stack could be asked to provide instructions for replicating these fixes in a fresh Claude session in the ioda-converters repo (if that hasn't already been done). What do others think?

@climbfuji

Copy link
Copy Markdown
Collaborator Author

Can we move forward with this PR? It's blocking the update to Python 3.13. Thanks.

@srherbener srherbener left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the utility of getting this PR merged in now so that the remainder of the Python 3.13 work can get completed. For this purpose I'm going to approve.

However, I'm concerned that we are going to miss all of these patches for ioda-converters and get bit by this later when we are testing jedi-bundle in ss-2.2. Could you submit an issue in ioda-converters to remind us of this work? Thanks!

@climbfuji

Copy link
Copy Markdown
Collaborator Author

I see the utility of getting this PR merged in now so that the remainder of the Python 3.13 work can get completed. For this purpose I'm going to approve.

However, I'm concerned that we are going to miss all of these patches for ioda-converters and get bit by this later when we are testing jedi-bundle in ss-2.2. Could you submit an issue in ioda-converters to remind us of this work? Thanks!

Done in JCSDA-internal/ioda-converters#1815

@climbfuji

Copy link
Copy Markdown
Collaborator Author

Thanks for the approvals! Will merge when the tests complete.

@srherbener

Copy link
Copy Markdown
Contributor

I see the utility of getting this PR merged in now so that the remainder of the Python 3.13 work can get completed. For this purpose I'm going to approve.
However, I'm concerned that we are going to miss all of these patches for ioda-converters and get bit by this later when we are testing jedi-bundle in ss-2.2. Could you submit an issue in ioda-converters to remind us of this work? Thanks!

Done in JCSDA-internal/ioda-converters#1815

@climbfuji thank you for submitting the issue! Much appreciated

@climbfuji
climbfuji merged commit f4d292f into JCSDA:develop Sep 11, 2026
6 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in spack-stack-2.2.x (2026 Q?) Sep 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

ioda and ioda-converters with Python 3.13 - ioda over constrained; ioda-converters: numpy 2 failures

3 participants