Build ioda and ioda-converters with Python 3.13 - #2117
Conversation
…lds and passes the ctests with python@3.13, py-numpy@2.1.4, and py-pandas@2.3.3
srherbener
left a comment
There was a problem hiding this comment.
The extensive patches to the ioda-converters python scripts seem, in general, updates that should be applied in the ioda-converters repo. I've had success in telling Claude to provide instructions for another Claude session to implement fixes. Ie, the session that created the patches for spack-stack could be asked to provide instructions for replicating these fixes in a fresh Claude session in the ioda-converters repo (if that hasn't already been done). What do others think?
|
Can we move forward with this PR? It's blocking the update to Python 3.13. Thanks. |
srherbener
left a comment
There was a problem hiding this comment.
I see the utility of getting this PR merged in now so that the remainder of the Python 3.13 work can get completed. For this purpose I'm going to approve.
However, I'm concerned that we are going to miss all of these patches for ioda-converters and get bit by this later when we are testing jedi-bundle in ss-2.2. Could you submit an issue in ioda-converters to remind us of this work? Thanks!
|
|
Thanks for the approvals! Will merge when the tests complete. |
@climbfuji thank you for submitting the issue! Much appreciated |
Description
Relax constraint on
pythonin ioda, patchioda-convertersso that it builds and passes the ctests withpython@3.13,py-numpy@2.1.4, andpy-pandas@2.3.3. See #2116 for the glorious details.This pull request is necessary to move forward with the update to
python@3.13for spack-stack release 2.2. It ensures that the answers ofioda-convertersdon't change when updating frompy-numpy@1.26.4topy-numpy@2.1.4.@mathomp4 @eap Please note that
py-pandasmust remain at version 2; the latest available version 2.3.3 works.Dependencies
None
Issues addressed
Closes #2116
Working toward #887
Applications affected
JEDI components installed in spack-stack environments
Systems affected
None
Testing
oops,ioda,ioda-converters,ropp-ufo, andufoversions as currently in spack-stack withgcc@14.2.1,python@3.13,py-numpy@2.1.4, andpy-pandas@2.3.3. The ctests all passed for each of these packages, except the ones explicitly included in the package recipes.Checklist
All dependency PRs/issues have been resolved and this PR can be merged.All necessary updates to the documentation (spack-stack wiki) will be made when this PR is merged