Fix/list operations and compiler safety - #162
Open
t0mg wants to merge 3 commits into
Open
Conversation
Ink Proof ResultsThese results are obtained by running the Ink-Proof Testing Suite on the compiled binaries in this pull request.
|
Owner
|
Thanks for the PR. |
t0mg
force-pushed
the
fix/list-operations-and-compiler-safety
branch
from
September 4, 2026 13:00
2e234cb to
4205e66
Compare
Author
|
Cool. I have a couple more PRs in stock but I'll wait for this one to land to make sure I'm doing it right. |
…r safety - Fix not_equal() in list_table: was returning equal(lh, rh) - Fix list comparisons (less, greater, less_equal, greater_equal) to compare assigned integer flag values rather than internal declaration indices - Fix LIST_VALUE evaluation to return get_flag_value() and support list operands - Prevent list truncation at 255 elements by widening index mask to 0xFFFF - Add bounds checking across listBegin(), hasList(), hasFlag(), and list iterators - Fix use-after-free in compiler: named_list_flag now owns std::string - Improve managed_array allocation safety with std::nothrow and nullptr guards
…risons
- list_impl.cpp: mask flag index with 0x7FFF instead of 0xFFFF: no negative flag by accident
- list_table.cpp: introduce found bool, since values could be negative
- list_table.h: rework less/greater/less_equal/greater_equal: no min/max -> empty list, empty list can be compared with
- stack.h: adapt print_dump() to tracing schema used in runner_impl.cpp
- list_table.h: fix include path ("include/list.h" -> "list.h"), "include" is defined as include path in `inkcpp/CMakeLists.txt`
JBenda
force-pushed
the
fix/list-operations-and-compiler-safety
branch
from
September 7, 2026 13:03
4205e66 to
616e01e
Compare
Owner
|
Hey, it took a while; I was double-checking the Thanks again for uncovering those additional issues—looking forward to seeing what else you find. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.