Repository navigation
Conversation
- Add StartupTimingRecorder singleton and StartupTimingScope RAII helper - Instrument plugin discovery, so load, dconfig creation, translation, applet load/create-root/init phases with timing scopes - Replace anonymous Benchmark class in appletloader with StartupTimingScope, preserving the original qCWarning timeout warning behavior - Add total_startup scope and JSON dump in main.cpp - Zero overhead when DDE_SHELL_BENCHMARK env var is not set - JSON report includes timestamp, version, pid, and samples array - Output path configurable via DDE_SHELL_BENCHMARK_OUTPUT env var
Phase 1 low-risk optimizations for async plugin loading: 1. Translation files lazy-loaded per-applet in load() instead of global recursive load in exec() 2. DConfig instances created lazily via ensureAppletConfig() on first isAppletEnabled() call, instead of bulk creation in ensureAppletConfigs() 3. .so libraries preloaded via posix_fadvise in background thread after metadata scan to warm OS page cache PMS: DDE-482 Log: 优化dde-shell插件加载性能,减少主线程阻塞 Bug: https://agentapi-dev.uniontech.com/multica/issue/DDE-482 fix: address code review issues for async-load phase 1 fix: 修复异步加载阶段一代码审核问题 1. Remove const from ensureAppletConfig() and isAppletEnabled(), eliminate all const_cast 2. Remove unnecessary mutable from m_appletConfigs and m_disabledPlugins 3. Remove unused #include <QSet> 4. Replace dlopen/dlclose with posix_fadvise to avoid ELF parsing and .init/.fini side effects Log: 修复代码审核中指出的const-correctness违规、不必要的mutable、死代码及dlopen副作用问题 Influence: shell/appletconfigmanager.h shell/appletconfigmanager.cpp frame/pluginloader.cpp cleanup: remove dead code and add preload failure log cleanup: 移除死代码并补充预加载失败日志 1. Remove no-op ensureAppletConfigs() call, declaration, and definition 2. Add qCDebug log for open() failure in preloadPluginLibraries() Log: 移除空的 ensureAppletConfigs() 死代码,补充 preload open 失败日志 Influence: 无功能影响,仅代码清理
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.