[SDK-705] IterablePushRegistrationTask as Runnable instead of AsyncTask - #1093
Open
franco-zalamena-iterable wants to merge 1 commit into
Open
franco-zalamena-iterable wants to merge 1 commit into
franco-zalamena-iterable wants to merge 1 commit into
Conversation
franco-zalamena-iterable
added this pull request to stack #1095
September 17, 2026 15:00
franco-zalamena-iterable
changed the title
rtlsilva
requested changes
Sep 21, 2026
| new IterablePushRegistrationTask().execute(data); | ||
| } | ||
| void executePushRegistrationTask(IterablePushRegistrationData data) { | ||
| executor.execute(new IterablePushRegistrationTask(data)); |
Contributor
There was a problem hiding this comment.
The new serial executor stops ordering the operations once ENABLE calls registerDeviceToken(), because that method starts another thread and returns.
A following DISABLE task can therefore enqueue /disableDevice before /registerDeviceToken, so a rapid login/logout sequence may leave the device enabled when registration lands last.
Suggest keeping registration request submission on this serial execution path and adding a deterministic enable-to-disable request-order test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
🎟️ Jira Ticket: SDK-705
📖 Description
First task replacing asyncTask with a regular Runnable and SDK owned Executor.
Made some changes to have the executor to be injectable and the behavior trackable from tests.