Skip to content

feat(runtime): bind task placeholders before dispatch - #46

Draft
i3ringit wants to merge 1 commit into
Intelligent-Internet:mainfrom
i3ringit:fix/pre-dispatch-task-binding
Draft

i3ringit wants to merge 1 commit into
Intelligent-Internet:mainfrom
i3ringit:fix/pre-dispatch-task-binding

Conversation

@i3ringit

@i3ringit i3ringit commented Oct 21, 2026 •

Copy link
Copy Markdown

Summary

  • add an orchestrator-only, one-shot bind_task_placeholders transition between plan submission and first dispatch
  • atomically persist the bound task body and privacy-safe audit metadata in tasks.json
  • serialize bind/advance/closure across server processes and fail closed on pre-attempt state or digest inconsistencies
  • preserve the audit through validated post-attempt task-list recovery

Closes #45

Tests

  • uv run pytest -q — 280 passed, 7 skipped
  • uv run ruff check . — passed
  • uv run mypy src — passed
  • git diff --check origin/main...HEAD — passed

Safety / limitations

  • worker and terminal-reviewer MCP surfaces remain unchanged
  • no dispatcher call or workspace sync occurs during binding
  • replacement values are stored only where required in the bound task body; audit metadata stores replacement SHA-256 digests
  • POSIX multiprocess lock paths are exercised; the Windows msvcrt branch is type-checked but not runtime-tested on this Linux host
  • seven existing real-ACP smoke tests remain skipped when their external binaries/services are unavailable

Candidate

  • base: a8d9b5786f81e70e73cce7bb164f5f83da84a4b5
  • head: ea26936a2a82c459c121117f0a5dabd2846488e6

- add one-shot audited post-submit task binding\n- serialize bind and dispatch across controller processes\n- preserve fail-closed task and audit state with focused tests\n\nCloses Intelligent-Internet#45
@i3ringit

Copy link
Copy Markdown
Author

Independent exact-head review: ACCEPT

  • reviewer: openai-codex/gpt-5.6-sol, reasoning high, fresh context
  • candidate: ea26936a2a82c459c121117f0a5dabd2846488e6
  • full diff: a8d9b5786f81e70e73cce7bb164f5f83da84a4b5...ea26936a2a82c459c121117f0a5dabd2846488e6
  • findings: no critical/high/medium/low findings
  • full tests: 280 passed, 7 skipped
  • focused binding/server tests: 37 passed
  • Ruff: passed
  • mypy: passed
  • diff check: passed
  • public MCP schema verified: _binding_audit not exposed; worker/reviewer surfaces unchanged

Hosted CI is currently action_required, so this PR remains draft and is not merge-qualified.

@i3ringit

Copy link
Copy Markdown
Author

Maintainer action requested: please approve the first-time contributor workflow run for exact head ea26936a2a82c459c121117f0a5dabd2846488e6 so the required Python 3.11–3.13 CI matrix can execute. The PR remains draft and unqualified until hosted CI completes successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add one-shot post-submit/pre-dispatch task binding

2 participants