Repository navigation
feat: Move reusable strings from mail to core for calendar - #881
Merged
Merged
Conversation
|
LunarX
enabled auto-merge
October 30, 2026 08:48
NicolasBourdin88
approved these changes
Oct 30, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The review found no active issues with the shared email-validation strings or their localized translations.
No open issues 🎉
What changed in this PR
This PR moves reusable email-validation strings into the shared Common module for use by the calendar and other consumers.
Changes:
- Adds
emailAlreadyUsedandemailInvalidto the default resources. - Adds localized translations for all supported locales.
- Notes a European Portuguese wording refinement for
emailAlreadyUsed.
| File | Description |
|---|---|
Common/src/main/res/values/strings.xml |
Adds the default English email-validation strings. |
Common/src/main/res/values-sv/strings.xml |
Adds Swedish translations. |
Common/src/main/res/values-pt/strings.xml |
Adds Portuguese translations; emailAlreadyUsed should use European Portuguese phrasing such as “O e-mail já está a ser utilizado.” |
Common/src/main/res/values-pl/strings.xml |
Adds Polish translations. |
Common/src/main/res/values-nl/strings.xml |
Adds Dutch translations. |
Common/src/main/res/values-nb/strings.xml |
Adds Norwegian Bokmål translations. |
Common/src/main/res/values-it/strings.xml |
Adds Italian translations. |
Common/src/main/res/values-fr/strings.xml |
Adds French translations. |
Common/src/main/res/values-fi/strings.xml |
Adds Finnish translations. |
Common/src/main/res/values-es/strings.xml |
Adds Spanish translations. |
Common/src/main/res/values-el/strings.xml |
Adds Greek translations. |
Common/src/main/res/values-de/strings.xml |
Adds German translations. |
Common/src/main/res/values-da/strings.xml |
Adds Danish translations. |
Review effort: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.