Repository navigation
Conversation
|
baillyjamy
approved these changes
Oct 27, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The annotation-only cleanup has no identified correctness or compatibility issues and leaves runtime logic unchanged.
No open issues 🎉
What changed in this PR
Removes obsolete experimental API opt-ins from shared authentication components without changing runtime logic.
Changes:
- Removes file-level type-inference and atomic API opt-ins.
- Removes the serialization opt-in around
decodeEnumsCaseInsensitive. - Deletes the corresponding unused imports.
| File | Description |
|---|---|
TwoFactorAuth/Back/WithUserDb/src/main/kotlin/TwoFactorAuthManagerWithUserDb.kt |
Removes the type-inference opt-in and import. |
TwoFactorAuth/Back/src/main/kotlin/TwoFactorAuthImpl.kt |
Removes the serialization opt-in and import. |
Auth/src/standard/kotlin/com/infomaniak/core/auth/backup/BlockStoreTestingImpl.kt |
Removes the atomic API opt-in and import. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.