Repository navigation
chore: Avoid infinite loop on unexpected errors in notifications worker scheduling - #877
Merged
LouisCAD merged 2 commits intoOct 26, 2026
Conversation
… scheduling Before, a 401 error could lead to a rescheduling loop.
…ssful This will help the status code getting through when a backend proxy replies with HTML.
LouisCAD
force-pushed
the
avoid-infinite-loop-on-unexpected-errors-in-notifications-worker-scheduling
branch
from
October 26, 2026 14:33
8eeb0f4 to
59443c1
Compare
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
A missing import blocks compilation, and terminal worker failures prevent subsequent topic changes from triggering registration.
2 open issues
What changed in this PR
This PR aims to prevent repeated notification-registration scheduling after unexpected failures in the shared Android library.
Changes:
- Distinguish terminal worker failures from successful completion and retryable errors.
- Stop the scheduling loop when registration work fails.
- Limit HTTP content-type validation to successful responses.
| File | Description |
|---|---|
| Notifications/Registration/src/main/kotlin/NotificationsRegistrationManager.kt | Stops rescheduling after worker failure. |
| Notifications/Registration/src/main/kotlin/AbstractNotificationsRegistrationWorker.kt | Reports terminal failures and exposes completion status. |
| Network/Ktor/src/main/kotlin/CreateHttpClient.kt | Skips content-type validation for unsuccessful responses. |
Review effort: Balanced
sirambd
approved these changes
Oct 26, 2026
LouisCAD
disabled auto-merge
October 26, 2026 15:12
LouisCAD
deleted the
avoid-infinite-loop-on-unexpected-errors-in-notifications-worker-scheduling
branch
October 26, 2026 15:12
LouisCAD
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.