Repository navigation
chore: Remove no longer needed null check & nested with - #876
Merged
Merged
Conversation
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The small refactor preserves existing behavior, matches the configured non-null response-body API, and has no unresolved findings.
No open issues 🎉
What changed in this PR
Simplifies the networking module’s gzip interceptor without changing its decompression behavior.
Changes:
- Removes the redundant response-body null check and non-null assertion.
- Replaces the conditional with
whenand removes the nestedwithblock.
| File | Description |
|---|---|
| Network/src/main/kotlin/com/infomaniak/core/network/networking/GZipInterceptor.kt | Simplifies gzip handling with direct response-body access. |
Review effort: Balanced
sirambd
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.