Repository navigation
chore: Replace multipart with url encoded forms - #875
Merged
Merged
Conversation
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused conversions preserve request parameters and handling, with no blocking issues identified in the supplied diffs.
No open issues 🎉
What changed in this PR
This PR switches OAuth token requests in the shared Login and Auth modules from multipart bodies to URL-encoded forms.
Changes:
- Replaces
MultipartBodywith OkHttpFormBodyfor login, token exchange, and token refresh requests. - Preserves all existing parameters, including conditional
access_typeanddurationfields.
| File | Description |
|---|---|
Login/src/main/java/com/infomaniak/core/login/InfomaniakLogin.kt |
Converts authorization-code and password token requests to URL-encoded forms. |
Auth/src/main/kotlin/com/infomaniak/core/auth/DerivedTokenGeneratorImpl.kt |
Converts derived-token exchange requests to URL-encoded forms. |
Auth/src/main/kotlin/com/infomaniak/core/auth/api/AuthRepository.kt |
Converts token refresh requests to URL-encoded forms. |
Review effort: Balanced
sirambd
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.