Skip to content

chore: Bump compose lints #865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LunarX merged 2 commits into from
Sep 24, 2026
Merged

chore: Bump compose lints #865

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
538f114
chore: Bump compose lints
LunarX Sep 24, 2026
9bb1232
feat: Regenerate lint-baselines for Core
LunarX Sep 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 3 additions & 25 deletions CrossAppLogin/Front/lint-baseline.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,9 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.13.0" type="baseline" client="gradle" dependencies="false" name="AGP (8.13.0)" variant="all" version="8.13.0">

<issue
id="ComposeModifierWithoutDefault"
message="This @Composable function has a modifier parameter but it doesn&apos;t have a default value.See https://slackhq.github.io/compose-lints/rules/#modifiers-should-have-default-parameters for more information."
errorLine1=" @SuppressLint(&quot;ModifierParameter&quot;) animatedButtonModifier: Modifier,"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/kotlin/com/infomaniak/core/crossapplogin/front/components/CrossLoginBottomContent.kt"
line="269"
column="5"/>
</issue>
<issues format="6" by="lint 9.3.2" type="baseline" client="gradle" dependencies="false" name="AGP (9.3.2)" variant="all" version="9.3.2">

<issue
id="ComposeParameterOrder"
message="Parameters in a composable function should be ordered following this pattern: params without defaults, modifiers, params with defaults and optionally, a trailing function that might not have a default param.&#xA;Current params are: [modifier: Modifier = Modifier, account: ExternalAccount, strokeColor: Color? = null] but should be [account: ExternalAccount, modifier: Modifier = Modifier, strokeColor: Color? = null].&#xA;See https://slackhq.github.io/compose-lints/rules/#ordering-composable-parameters-properly for more information."
message="Parameters in a composable function should be ordered following this pattern: params without defaults, modifiers, params with defaults and optionally, a trailing function that might not have a default param.&#xA;Current params are: `[modifier: Modifier = Modifier, account: ExternalAccount, strokeColor: Color? = null]` but should be `[account: ExternalAccount, modifier: Modifier = Modifier, strokeColor: Color? = null]`.&#xA;See https://slackhq.github.io/compose-lints/rules/#ordering-composable-parameters-properly for more information."
errorLine1="internal fun CrossLoginAvatar(modifier: Modifier = Modifier, account: ExternalAccount, strokeColor: Color? = null) {"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
Expand All @@ -25,18 +14,7 @@

<issue
id="ComposeParameterOrder"
message="Parameters in a composable function should be ordered following this pattern: params without defaults, modifiers, params with defaults and optionally, a trailing function that might not have a default param.&#xA;Current params are: [primaryButtonType: ButtonStyle, isLoginButtonLoading: () -> Boolean, modifier: Modifier = Modifier, text: String, onClick: () -> Unit] but should be [primaryButtonType: ButtonStyle, isLoginButtonLoading: () -> Boolean, text: String, modifier: Modifier = Modifier, onClick: () -> Unit].&#xA;See https://slackhq.github.io/compose-lints/rules/#ordering-composable-parameters-properly for more information."
errorLine1="private fun ConnectionButton("
errorLine2=" ^">
<location
file="src/main/kotlin/com/infomaniak/core/crossapplogin/front/components/CrossLoginBottomContent.kt"
line="364"
column="29"/>
</issue>

<issue
id="ComposeParameterOrder"
message="Parameters in a composable function should be ordered following this pattern: params without defaults, modifiers, params with defaults and optionally, a trailing function that might not have a default param.&#xA;Current params are: [modifier: Modifier = Modifier, text: String, customization: CrossLoginCustomization, onClick: () -> Unit] but should be [text: String, customization: CrossLoginCustomization, modifier: Modifier = Modifier, onClick: () -> Unit].&#xA;See https://slackhq.github.io/compose-lints/rules/#ordering-composable-parameters-properly for more information."
message="Parameters in a composable function should be ordered following this pattern: params without defaults, modifiers, params with defaults and optionally, a trailing function that might not have a default param.&#xA;Current params are: `[modifier: Modifier = Modifier, text: String, customization: CrossLoginCustomization, onClick: () -> Unit]` but should be `[text: String, customization: CrossLoginCustomization, modifier: Modifier = Modifier, onClick: () -> Unit]`.&#xA;See https://slackhq.github.io/compose-lints/rules/#ordering-composable-parameters-properly for more information."
errorLine1="internal fun PrimaryButton("
errorLine2=" ^">
<location
Expand Down
6 changes: 3 additions & 3 deletions InAppUpdate/lint-baseline.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.13.0" type="baseline" client="gradle" dependencies="false" name="AGP (8.13.0)" variant="all" version="8.13.0">
<issues format="6" by="lint 9.3.2" type="baseline" client="gradle" dependencies="false" name="AGP (9.3.2)" variant="all" version="9.3.2">

<issue
id="ComposeModifierWithoutDefault"
message="This @Composable function has a modifier parameter but it doesn&apos;t have a default value.See https://slackhq.github.io/compose-lints/rules/#modifiers-should-have-default-parameters for more information."
message="This @Composable function has a modifier parameter but it doesn&apos;t have a default value.&#xA;&#xA;See https://slackhq.github.io/compose-lints/rules/#modifiers-should-have-default-parameters for more information."
errorLine1=" modifier: Modifier,"
errorLine2=" ~~~~~~~~~~~~~~~~~~">
<location
Expand All @@ -14,7 +14,7 @@

<issue
id="ComposeParameterOrder"
message="Parameters in a composable function should be ordered following this pattern: params without defaults, modifiers, params with defaults and optionally, a trailing function that might not have a default param.&#xA;Current params are: [topContent: @Composable () -> Unit = {}, modifier: Modifier, titleTextStyle: TextStyle, descriptionTextStyle: TextStyle] but should be [modifier: Modifier, titleTextStyle: TextStyle, descriptionTextStyle: TextStyle, topContent: @Composable () -> Unit = {}].&#xA;See https://slackhq.github.io/compose-lints/rules/#ordering-composable-parameters-properly for more information."
message="Parameters in a composable function should be ordered following this pattern: params without defaults, modifiers, params with defaults and optionally, a trailing function that might not have a default param.&#xA;Current params are: `[topContent: @Composable () -> Unit = {}, modifier: Modifier, titleTextStyle: TextStyle, descriptionTextStyle: TextStyle]` but should be `[modifier: Modifier, titleTextStyle: TextStyle, descriptionTextStyle: TextStyle, topContent: @Composable () -> Unit = {}]`.&#xA;See https://slackhq.github.io/compose-lints/rules/#ordering-composable-parameters-properly for more information."
errorLine1="private fun UpdateRequiredContent("
errorLine2=" ^">
<location
Expand Down
4 changes: 2 additions & 2 deletions KSuite/KSuitePro/lint-baseline.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.13.0" type="baseline" client="gradle" dependencies="false" name="AGP (8.13.0)" variant="all" version="8.13.0">
<issues format="6" by="lint 9.3.2" type="baseline" client="gradle" dependencies="false" name="AGP (9.3.2)" variant="all" version="9.3.2">

<issue
id="ComposeModifierWithoutDefault"
message="This @Composable function has a modifier parameter but it doesn&apos;t have a default value.See https://slackhq.github.io/compose-lints/rules/#modifiers-should-have-default-parameters for more information."
message="This @Composable function has a modifier parameter but it doesn&apos;t have a default value.&#xA;&#xA;See https://slackhq.github.io/compose-lints/rules/#modifiers-should-have-default-parameters for more information."
errorLine1=" modifier: Modifier,"
errorLine2=" ~~~~~~~~~~~~~~~~~~">
<location
Expand Down
Loading
Loading