Skip to content

fix(mcp): flag deprecated IgbDataGrid and point to IgbGrid instead - #1833

Merged
kdinev merged 10 commits into
masterfrom
ibarakov/fix-1832
Oct 9, 2026
Merged

kdinev merged 10 commits into
masterfrom
ibarakov/fix-1832

Conversation

@onlyexeption

Copy link
Copy Markdown
Contributor

Description

Related Issue

Closes #1832

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Refactoring / code cleanup
  • Build / CI configuration change

Affected Packages

  • igniteui-cli (packages/cli)
  • @igniteui/cli-core (packages/core)
  • @igniteui/angular-templates (packages/igx-templates)
  • @igniteui/angular-schematics (packages/ng-schematics)
  • @igniteui/mcp-server (packages/igniteui-mcp)

Checklist

  • I have tested my changes locally (npm run test)
  • I have built the project successfully (npm run build)
  • I have run the linter (npm run lint)
  • I have added/updated tests as needed
  • My changes do not introduce new warnings or errors

Additional Context

Comment thread packages/igniteui-mcp/igniteui-doc-mcp/src/config/deprecations.ts Fixed
@coveralls

coveralls commented Oct 5, 2026 •

Copy link
Copy Markdown

Coverage Status

Coverage is 94.559% — ibarakov/fix-1832 into master. No base build found for master.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

A Blazor legacy-grid enum remains available without deprecation guidance.

Review effort: Balanced
Findings: 1 Medium severity

Open (1)
What changed in this PR

Adds MCP deprecation handling for Blazor’s IgbDataGrid, directing assistants toward IgbGrid and IgbColumn for issue #1832.

Changes:

  • Adds a registry and notices for deprecated grid symbols.
  • Filters deprecated API entries and integrates notices into tool responses.
  • Adds registry, loader, and handler regression tests.
File Description
packages/​igniteui-mcp/​igniteui-doc-mcp/​src/​tools/​handlers.ts Adds API search, reference, and import notices.
packages/​igniteui-mcp/​igniteui-doc-mcp/​src/​lib/​api-doc-loader.ts Excludes registered deprecated symbols.
packages/​igniteui-mcp/​igniteui-doc-mcp/​src/​index.ts Adds notices to documentation responses.
packages/​igniteui-mcp/​igniteui-doc-mcp/​src/​config/​deprecations.ts Defines deprecated symbols and replacement guidance.
packages/​igniteui-mcp/​igniteui-doc-mcp/​src/​__tests__/​tools/​handlers.test.ts Tests tool deprecation responses.
packages/​igniteui-mcp/​igniteui-doc-mcp/​src/​__tests__/​lib/​api-doc-loader.test.ts Tests deprecated-entry filtering.
packages/​igniteui-mcp/​igniteui-doc-mcp/​src/​__tests__/​config/​deprecations.test.ts Tests symbol matching and notices.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread packages/igniteui-mcp/igniteui-doc-mcp/src/config/deprecations.ts

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Two moderate issues remain unresolved, along with a test coverage nit.

0 open findings

1 resolved since last review
Previously missed (1)

In code that hasn't changed since last review

Medium severity Preserve errors when unresolved symbols accompany deprecated symbols

packages/​igniteui-mcp/​igniteui-doc-mcp/​src/​tools/​handlers.ts:250

When a call contains only deprecated symbols plus an unknown symbol, byPlatform remains empty but deprecated.size is nonzero, so this suppresses isError even though the unknown symbol is unresolved. For example, resolve_import({ symbols: ['IgbDataGrid', 'NotARealSymbol'], platform: 'blazor' }) returns only the deprecation notice as a successful response; keep the error status for calls where every non-deprecated result is unresolved.

🧠 Review effort: Lite


Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The deprecation registry does not cover all IgbDataGrid-only related types, leaving some deprecated symbols discoverable.

1 open finding

🧠 Review effort: Lite


Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.

Comment thread packages/igniteui-mcp/igniteui-doc-mcp/src/config/deprecations.ts
@onlyexeption
onlyexeption requested a lite review from Copilot October 8, 2026 13:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Two moderate deprecation-registry issues remain unresolved.

0 open findings

1 resolved since last review

🧠 Review effort: Lite


Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Three moderate gaps remain in deprecated symbol coverage and platform resolution.

0 open findings

🧠 Review effort: Lite


Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The deprecation registry is overbroad and incomplete, and list_components can still expose IgbDataGrid without a warning.

1 open finding

🧠 Review effort: Lite


Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.

Comment thread packages/igniteui-mcp/igniteui-doc-mcp/src/config/deprecations.ts

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The remaining candidate finding was contradicted by the lookup code, leaving no unresolved actionable findings.

0 open findings

1 resolved since last review

🧠 Review effort: Lite

@kdinev
kdinev merged commit 8110cbc into master Oct 9, 2026
5 checks passed
@kdinev
kdinev deleted the ibarakov/fix-1832 branch October 9, 2026 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MCP recommends deprecated IgbDataGrid for Blazor

6 participants