Repository navigation
fix(tabs): call markForCheck after each Promise.resolve().then() - 21.2.x - #17746
Open
igdmdimitrov wants to merge 2 commits into
Open
igdmdimitrov wants to merge 2 commits into
igdmdimitrov wants to merge 2 commits into
Conversation
igdmdimitrov
added
❌ status: awaiting-test
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The new spec has an invalid import and class assertion, and collection-change paths lack zoneless coverage.
Review effort: Balanced
Findings: 2
Open (3)
What changed in this PR
Fixes zoneless tab selection rendering by scheduling change detection after deferred updates.
Changes:
- Calls
markForCheck()after deferred tab selection updates. - Adds a zoneless regression test.
- Documents the fix in the changelog.
| File | Description |
|---|---|
tabs.directive.ts |
Schedules change detection after deferred selection updates. |
tabs.component.spec.ts |
Adds zoneless initial-selection coverage. |
CHANGELOG.md |
Records the tabs bug fix. |
| import { TestBed, fakeAsync, tick, waitForAsync } from '@angular/core/testing'; | ||
| import { IgxTabItemComponent } from './tab-item.component'; | ||
| import { IgxTabsAlignment, IgxTabsComponent } from './tabs.component'; | ||
| import { IgxTabHeaderComponent } from './header/tab-header.component'; |
| // reflected in the DOM even though nothing else triggers change detection. | ||
| expect(tabs.selectedIndex).toBe(0); | ||
| expect(tabs.selectedItem.selected).toBeTrue(); | ||
| expect(firstHeader.classList.contains('igx-tab-header--selected')).toBeTrue(); |
| // Set the selected index to the tab that has selected=true | ||
| Promise.resolve().then(() => { | ||
| this.selectedIndex = selectedIndex; | ||
| this._cdr.markForCheck(); |
igdmdimitrov
added
🛠️ status: in-development
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17676
Type of Change (check all that apply):
How Has This Been Tested?
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)