Repository navigation
fix(tabs): call markForCheck after each Promise.resolve().then() - 22.2.x - #17736
Open
igdmdimitrov wants to merge 5 commits into
Open
igdmdimitrov wants to merge 5 commits into
igdmdimitrov wants to merge 5 commits into
Conversation
igdmdimitrov
added
❌ status: awaiting-test
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The fix covers every affected deferred selection branch with focused zoneless regression tests.
Review effort: Balanced
Findings: None
What changed in this PR
Fixes zoneless tab selection rendering by explicitly scheduling change detection after deferred selection updates.
Changes:
- Calls
markForCheck()after all deferred tab-selection mutations. - Adds zoneless tests for initialization and dynamic tab collections.
| File | Description |
|---|---|
tabs.directive.ts |
Schedules checks after asynchronous selection updates. |
tabs.component.spec.ts |
Tests zoneless selection rendering paths. |
tabs-components.spec.ts |
Adds signal-backed test hosts for dynamic tabs. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Contributor
Author
|
@copilot , update the changelog.md with information about this bug fix. This should be added in the latest 22.2.x version. |
Co-authored-by: igdmdimitrov <49060557+igdmdimitrov@users.noreply.github.com>
Contributor
Added the |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17676
Type of Change (check all that apply):
How Has This Been Tested?
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)