Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused implementation is supported by coverage for the reported regression and related accordion behavior.
Review effort: Balanced
Findings: None
What changed in this PR
Fixes accordion initialization state synchronization and expands regression coverage.
Changes:
- Makes expansion-panel collapsed state signal-backed.
- Adds accordion lifecycle, navigation, cancellation, animation, and dynamic-panel tests.
- Documents the fix in the changelog.
| File | Description |
|---|---|
expansion-panel.component.ts |
Reactively synchronizes collapsed state and ARIA bindings. |
accordion.component.spec.ts |
Adds comprehensive accordion regression coverage. |
CHANGELOG.md |
Records the initialization and ARIA fix. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding more test coverage.
Bug Fixes
IgxAccordionComponentsingleBranchExpandis set initially and the panels are rendered with@for, the panels collapsed on init no longer keeparia-expanded="true"and noExpressionChangedAfterItHasBeenCheckedErroris thrown in development mode.Motivation / Context
The accordion had insufficient test coverage.
Type of Change (check all that apply):
Component(s) / Area(s) Affected:
Accordion, Expansion Panel
How Has This Been Tested?
Test Configuration:
Screenshots / Recordings
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)