Repository navigation
Remove the broken Graphs.weights overload for tensor networks - #201
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #201 +/- ##
==========================================
+ Coverage 87.19% 88.34% +1.15%
==========================================
Files 16 16
Lines 687 678 -9
==========================================
Hits 599 599
+ Misses 88 79 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mtfishman
enabled auto-merge (squash)
October 3, 2026 01:16
jack-dunham
pushed a commit
to jack-dunham/ITensorNetworksNext.jl
that referenced
this pull request
Oct 6, 2026
…sor#201) ## Summary Removes `Graphs.weights`, which called a one-argument `dim` that does not exist in this stack. It threw a `MethodError` for any network with an edge, and nothing called it. Without the overload, Graphs' own `weights` applies, returning an `AbstractMatrix` of the kind the NamedGraphs shortest-path algorithms expect. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
jack-dunham
pushed a commit
to jack-dunham/ITensorNetworksNext.jl
that referenced
this pull request
Oct 7, 2026
…sor#201) ## Summary Removes `Graphs.weights`, which called a one-argument `dim` that does not exist in this stack. It threw a `MethodError` for any network with an edge, and nothing called it. Without the overload, Graphs' own `weights` applies, returning an `AbstractMatrix` of the kind the NamedGraphs shortest-path algorithms expect. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes
Graphs.weights, which called a one-argumentdimthat does not exist in this stack. It threw aMethodErrorfor any network with an edge, and nothing called it. Without the overload, Graphs' ownweightsapplies, returning anAbstractMatrixof the kind the NamedGraphs shortest-path algorithms expect.