Repository navigation
Use geometric mean for HIT energy bin centers - #3574
Merged
daralynnrhode merged 1 commit intoOct 19, 2026
Merged
daralynnrhode merged 1 commit into
daralynnrhode merged 1 commit into
Conversation
daralynnrhode
added
bug
lacoak21
approved these changes
Oct 19, 2026
lacoak21
left a comment
lacoak21
left a comment
Contributor
There was a problem hiding this comment.
Nice job! This looks great.
daralynnrhode
merged commit Oct 19, 2026
a47f346
into
IMAP-Science-Operations-Center:dev
22 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing the Energy Bin Centers to be the Geometric Mean
Overview
The energy mean variables were listed as geometric means in the L1A and L1B CDF attributes, but
add_energy_variables()computed the arithmetic midpoint [(min + max) / 2] instead of [sqrt(min * max)].The values were hardcoded into the original tests, so I just updated them to calculate and check for the geometric mean instead.
closes #3562
File changes
Testing
test_hit_utils.pyUpdated two tests that expected arithmetic means. No validation data includes energy values.