Repository navigation
Imap-Lo: Label histogram bins with their spin angle, including the spin-start offset - #3566
Open
vineetbansal wants to merge 3 commits into
Open
vineetbansal wants to merge 3 commits into
vineetbansal wants to merge 3 commits into
Conversation
vineetbansal
changed the title
tmplummer
reviewed
Oct 15, 2026
tmplummer
left a comment
tmplummer
left a comment
Contributor
There was a problem hiding this comment.
Maybe jumping the gun on review. Looks good other than the instrument frame question.
| n_bins = l1b_histrates.sizes["spin_bin_6"] | ||
| bin_centers = (np.arange(n_bins) + 0.5) * (360.0 / n_bins) | ||
| mounting_offset = 360.0 * get_spacecraft_to_instrument_spin_phase_offset( | ||
| SpiceFrame.IMAP_LO |
Contributor
There was a problem hiding this comment.
This will be updated to SpiceFrame.IMAP_LO_INSTR right?
Collaborator
Author
There was a problem hiding this comment.
You're right - in the process I discovered that dependencies need to be updated before I tweak this and it is merged. PR 1728 in sds-data-manager addresses this.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3561