Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The regression path needs tests, and its log message currently misdiagnoses other empty-data conditions.
1 open finding
What changed in this PR
Gracefully handles SWAPI L1 science inputs without valid HVSCI sweep data.
Changes:
- Returns
Nonewhen no processable science sweeps remain. - Converts that result to an empty dataset list for the CLI.
| File | Description |
|---|---|
imap_processing/swapi/l1/swapi_l1.py |
Adds empty-science handling and updates return types. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
lacoak21
merged commit Oct 19, 2026
1723662
into
IMAP-Science-Operations-Center:dev
22 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
closes #3564
Overview
There were two dates in october 2025 (6th and 19th) where processing failed. This was due to the fact that there were no packets in HVSCI mode. When this occurs we should exit the job gracefully since there is no relevant data to process.
File changes