Repository navigation
fix(inference): honor explicit g_max reference in noise models - #835
Closed
PabloCarmona wants to merge 4 commits into
Closed
PabloCarmona wants to merge 4 commits into
PabloCarmona wants to merge 4 commits into
Conversation
An explicit coeff_g_max_reference / prog_coeff_g_max_reference raised an AttributeError in ReRamWan2022NoiseModel, PCMLikeNoiseModel (and so CustomDriftPCMLikeNoiseModel) and HermesNoiseModel when custom coefficients were used, and was silently overwritten by the default reference otherwise. An explicit value now always takes precedence. ReRamWan2022NoiseModel also never applied the 40 uS reference of its default coefficients, so noise is now scaled by g_max / 40 as documented (Fixes #830). Signed-off-by: Pablo Carmona Gonzalez <pablocarmonagonzalez@gmail.com>
…model Restore the elif for the single-device case instead of a catch-all else, so each supported num_devices value is handled explicitly. The default reference falls back to g_max, so no branch leaves it undefined. Signed-off-by: Pablo Carmona Gonzalez <pablocarmonagonzalez@gmail.com>
The reference is now inferred as float, which conflicts with the legacy loader assigning the optional g_max to it. Signed-off-by: Pablo Carmona Gonzalez <pablocarmonagonzalez@gmail.com>
Signed-off-by: Pablo Carmona Gonzalez <pablocarmonagonzalez@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
Fixes #830
Description
An explicit coeff_g_max_reference / prog_coeff_g_max_reference raised an AttributeError in ReRamWan2022NoiseModel, PCMLikeNoiseModel (and so CustomDriftPCMLikeNoiseModel) and HermesNoiseModel when custom coefficients were used, and was silently overwritten by the default reference otherwise. An explicit value now always takes precedence.
ReRamWan2022NoiseModel also never applied the 40 uS reference of its default coefficients, so noise is now scaled by g_max / 40 as documented.
Details
N/A