Skip to content

chore(github): add CODEOWNERS for packages/ui, docs and packages/docs - #231

Merged
HsiangNianian merged 3 commits into
mainfrom
krypton/chore-github-add-codeowners-for-packages-j08d8b0
Oct 23, 2026
Merged

HsiangNianian merged 3 commits into
mainfrom
krypton/chore-github-add-codeowners-for-packages-j08d8b0

Conversation

@hydroroll-bot

@hydroroll-bot hydroroll-bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Member

加几行 CODEOWNERS,让相关 PR 自动 request review:

/packages/ui/     @muyuzhong
/docs/            @NtskwK
/packages/docs/   @NtskwK

/packages/ui/ 归 @muyuzhong,前端相关 PR 会自动 request review;/docs/ 和 /packages/docs/ 归 @NtskwK,是 PR 开出来之后按 maintainer 的追加要求补的,两条都确认过目录存在于仓库根下。

改动就一个文件 .github/CODEOWNERS,+3 -0,没动别的文件。这类改动不涉及代码,本地没跑测试(也没意义),CI 该跑什么照跑。

分支保护里的 Require review from Code Owners 简律纯自己去勾,勾上这些规则才生效。


由 Krypton(hydroroll-bot)应群里可信成员的请求自动生成,是草稿,需要人审查后再合并。

@sourcery-ai

sourcery-ai Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds a CODEOWNERS rule assigning /packages/ui/ to @muyuzhong, so relevant pull requests can automatically request their review; no application code or tests are changed.

File-Level Changes

Change Details Files
Assigns ownership of the UI package to a designated reviewer through GitHub CODEOWNERS.
  • Adds a /packages/ui/ @muyuzhong ownership rule.
  • Enables automatic review requests for matching pull requests when branch protection requires Code Owner approval.
.github/CODEOWNERS

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

📦 Semifold release plan

Plan calculated through commit 1de7761.

Note

This pull request does not introduce any changesets.

After this pull request is merged into main, the release workflow will run and publish any prepared package versions that are not yet available in their registry.

This comment updates automatically as the pull request changes.

@hydroroll-bot

Copy link
Copy Markdown
Member Author

按 @简律纯 的要求补了一行:/docs/ @NtskwK。

现在的 .github/CODEOWNERS:

/packages/ui/ @muyuzhong
/docs/ @NtskwK

原来 /packages/ui/ @muyuzhong 那行一字没动,其他文件也没碰,doc 目录确认是存在的(仓库根下的 docs/)。

只改了 CODEOWNERS 文本,不涉及构建,没跑 cargo / pnpm 那些。CODEOWNERS 语法就是 path + 空格 + owner,两行格式一致。

追加了 1 个签名提交。实际推上去的:56edc22 chore(github): add CODEOWNERS for packages/ui(作者 hydroroll-bot);99073ad chore(github): add CODEOWNERS for docs(作者 hydroroll-bot)(chore(github): add CODEOWNERS for docs)。

@hydroroll-bot

Copy link
Copy Markdown
Member Author

按要求加了一行。

现在 .github/CODEOWNERS 是:

/packages/ui/ @muyuzhong
/docs/ @NtskwK
/packages/docs/ @NtskwK

原来那两行没动,其他文件也没碰,就追加了这一个提交。这种文件没有测试可跑,只看了一眼格式没写错。

追加了 1 个签名提交。实际推上去的:56edc22 chore(github): add CODEOWNERS for packages/ui(作者 hydroroll-bot);99073ad chore(github): add CODEOWNERS for docs(作者 hydroroll-bot);1de7761 chore(github): add CODEOWNERS for packages/docs(作者 hydroroll-bot)(chore(github): add CODEOWNERS for packages/docs)。

@HsiangNianian HsiangNianian self-assigned this Oct 23, 2026
@HsiangNianian
HsiangNianian marked this pull request as ready for review October 23, 2026 06:38
Copilot AI balanced review requested due to automatic review settings October 23, 2026 06:38
@hydroroll-bot

Copy link
Copy Markdown
Member Author

收到,谢谢审查 🙏

CI 跑完没问题的话就等你合并了。后面要再补 CODEOWNERS 条目也随时说。

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The additional documentation ownership assignments need confirmation and an updated description, or removal to match the stated scope.

1 open issue
What changed in this PR

Adds GitHub code-owner rules to route review requests for the launcher's UI and documentation.

Changes:

  • Assigns /packages/ui/ to @muyuzhong.
  • Also assigns /docs/ and /packages/docs/ to @NtskwK, beyond the described UI-only scope.
File Description
.github/​CODEOWNERS Adds ownership rules for the UI package and both documentation directories.

Review effort: Balanced

Comment thread .github/CODEOWNERS
@hydroroll-bot

Copy link
Copy Markdown
Member Author

Thanks for the catch — the scope mismatch is real. The /docs/ and /packages/docs/ lines aren't something I added on my own: they came in as a follow-up request from a maintainer in the project chat, after the PR was already open. So the diff is intentional, the description just never got updated to match.

Rather than dropping the rules, the better fix is on the description side:

  • PR body should read as "add CODEOWNERS for packages/ui, plus docs and packages/docs", not UI-only.
  • No app code or tests touched; +3 -0 in one file is still accurate.

I can't edit the PR body from here, so @NtskwK / @muyuzhong — one of you confirm the docs ownership assignments are intended, and whoever has write access can update the description (or tell me and I'll push a matching commit message/note). Until then, treat the docs rules as awaiting confirmation rather than a mistake.

@HsiangNianian

Copy link
Copy Markdown
Member

Thanks for the catch — the scope mismatch is real. The /docs/ and /packages/docs/ lines aren't something I added on my own: they came in as a follow-up request from a maintainer in the project chat, after the PR was already open. So the diff is intentional, the description just never got updated to match.

Rather than dropping the rules, the better fix is on the description side:

  • PR body should read as "add CODEOWNERS for packages/ui, plus docs and packages/docs", not UI-only.
  • No app code or tests touched; +3 -0 in one file is still accurate.

I can't edit the PR body from here, so @NtskwK / @muyuzhong — one of you confirm the docs ownership assignments are intended, and whoever has write access can update the description (or tell me and I'll push a matching commit message/note). Until then, treat the docs rules as awaiting confirmation rather than a mistake.

现在你可以修改了,把 PR 说明改成和改动一致吧

@hydroroll-bot hydroroll-bot changed the title chore(github): add CODEOWNERS for packages/ui chore(github): add CODEOWNERS for packages/ui, docs and packages/docs Oct 23, 2026
@hydroroll-bot

Copy link
Copy Markdown
Member Author

改好了,标题也一起改了:「chore(github): add CODEOWNERS for packages/ui, docs and packages/docs」。

说明里现在写清了三行、各自归谁,也说明了 /docs/ 和 /packages/docs/ 是按追加要求补的、不是顺手加的,+3 -0 一个文件没变。你刷新一下看看措辞,不对我再调。

#231

@HsiangNianian
HsiangNianian merged commit 2cf232e into main Oct 23, 2026
22 checks passed
@HsiangNianian
HsiangNianian deleted the krypton/chore-github-add-codeowners-for-packages-j08d8b0 branch October 23, 2026 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants