Repository navigation
chore(github): add CODEOWNERS for packages/ui, docs and packages/docs - #231
HsiangNianian merged 3 commits into
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds a CODEOWNERS rule assigning File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
📦 Semifold release planPlan calculated through commit 1de7761. Note This pull request does not introduce any changesets. After this pull request is merged into This comment updates automatically as the pull request changes. |
|
按 @简律纯 的要求补了一行: 现在的 原来 只改了 CODEOWNERS 文本,不涉及构建,没跑 cargo / pnpm 那些。CODEOWNERS 语法就是 path + 空格 + owner,两行格式一致。 追加了 1 个签名提交。实际推上去的: |
|
按要求加了一行。 现在 .github/CODEOWNERS 是: 原来那两行没动,其他文件也没碰,就追加了这一个提交。这种文件没有测试可跑,只看了一眼格式没写错。 追加了 1 个签名提交。实际推上去的: |
|
收到,谢谢审查 🙏 CI 跑完没问题的话就等你合并了。后面要再补 CODEOWNERS 条目也随时说。 |
There was a problem hiding this comment.
🟡 Changes recommended
The additional documentation ownership assignments need confirmation and an updated description, or removal to match the stated scope.
1 open issue
What changed in this PR
Adds GitHub code-owner rules to route review requests for the launcher's UI and documentation.
Changes:
- Assigns
/packages/ui/to @muyuzhong. - Also assigns
/docs/and/packages/docs/to @NtskwK, beyond the described UI-only scope.
| File | Description |
|---|---|
.github/CODEOWNERS |
Adds ownership rules for the UI package and both documentation directories. |
Review effort: Balanced
|
Thanks for the catch — the scope mismatch is real. The Rather than dropping the rules, the better fix is on the description side:
I can't edit the PR body from here, so @NtskwK / @muyuzhong — one of you confirm the docs ownership assignments are intended, and whoever has write access can update the description (or tell me and I'll push a matching commit message/note). Until then, treat the docs rules as awaiting confirmation rather than a mistake. |
现在你可以修改了,把 PR 说明改成和改动一致吧 |
|
改好了,标题也一起改了:「chore(github): add CODEOWNERS for packages/ui, docs and packages/docs」。 说明里现在写清了三行、各自归谁,也说明了 |

加几行 CODEOWNERS,让相关 PR 自动 request review:
/packages/ui/归 @muyuzhong,前端相关 PR 会自动 request review;/docs/和/packages/docs/归 @NtskwK,是 PR 开出来之后按 maintainer 的追加要求补的,两条都确认过目录存在于仓库根下。改动就一个文件
.github/CODEOWNERS,+3 -0,没动别的文件。这类改动不涉及代码,本地没跑测试(也没意义),CI 该跑什么照跑。分支保护里的 Require review from Code Owners 简律纯自己去勾,勾上这些规则才生效。
由 Krypton(hydroroll-bot)应群里可信成员的请求自动生成,是草稿,需要人审查后再合并。