Repository navigation
fix(docs): configure production Workers deployment - #226
Conversation
Reviewed-by: GPT-6
Reviewer's guide (collapsed on small PRs)Reviewer's GuideConfigures the documentation Worker for production Cloudflare Workers Builds from File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
📦 Semifold release planPlan calculated through commit 858cbdb. Note This pull request does not introduce any changesets. After this pull request is merged into This comment updates automatically as the pull request changes. |
There was a problem hiding this comment.
🟢 Approval recommended
The changes are narrowly scoped, align with the existing deployment configuration, and have no identified blocking issues.
No open issues 🎉
What changed in this PR
Pins the documentation Worker to the Hydroroll Cloudflare account and documents production deployment using the existing workspace build.
Changes:
- Set the Worker’s Cloudflare account ID.
- Document
maindeployment settings, watched paths, and secret handling. - Use frozen dependency installation for deployment validation.
| File | Description |
|---|---|
wrangler.jsonc |
Pins the documentation Worker’s Cloudflare account. |
docs/cloudflare-deployment.md |
Documents production settings and updates validation commands. |
Review effort: Balanced
There was a problem hiding this comment.
Hey - I've reviewed your changes and they look great!
Sourcery assessment
Needs a human reviewer. The new account_id directs Wrangler deployments to a Cloudflare account; if it points to the wrong account and the build token can deploy there, the deployment could publish the Worker in the wrong place or disrupt the intended production deployment. Reverting the config does not undo an already-published deployment; it would need a corrective deployment.
Disable Wrangler name helpers so serialized theme scripts run in the browser without __name errors. Reviewed-by: GPT-6
Deploy documentation from
mainto the Hydroroll Cloudflare account and document the Workers Builds branch, path filters, and pinned build tools.Disable Wrangler function-name helpers because the serialized theme bootstrap otherwise throws
__name is not definedin the browser and causes hydration errors.Validation: pinned pnpm frozen install, documentation build/typecheck, Wrangler deployment dry run, and pre-commit checks passed. Browser checks against the local Workers runtime pass with no JavaScript errors, working search, and light/dark theme switching.
Summary by Sourcery
Configure reliable production Workers deployments for the documentation site and prevent browser hydration failures in the generated Worker bundle.
Bug Fixes:
Enhancements:
Build:
Deployment:
Documentation: