Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #633.
With
x = "stuff",{{ x[0] }}currently renders nothing and reports an unknown property, while{{ x[0:1] }}renderss. Add an internal string resolver before the bean resolver in both default resolver chains so indexed access returns the expected character as aString.Support positive and negative integer indices, including numeric index strings. Empty strings, out-of-range indices, and integer overflow resolve to
null. Preserve non-index property/method fallback, custom resolvers, and string immutability. Indexing follows the existing UTF-16 boundaries used by string slices and the length filter; other object types andSafeStringhandling are unchanged. No public API, configuration, or dependency changes.Validation
0eb936cbefore applying the fix.verifywith Temurin 17, 21, and 25: 2,254 tests per run, 0 failures/errors, 23 skipped. Maven runs on JDK 25 with the selected compiler/test toolchain; the 21/25 builds used fresh checkouts.git diff --checkfound no issues.en_US. The existingFormatNumberFilterTestfails on untouched upstream under this Mac'sde_ATlocale and passes withen_US; no unrelated source changes were made.Implemented with assistance from OpenAI Codex.