Repository navigation
big bug hunt #2 - various issues per Josh's report - #335
Merged
Merged
Conversation
jmandel
added a commit
to jmandel/FHIRsmith
that referenced
this pull request
Nov 3, 2026
HealthIntersections#335 anchors regex filters as ^(?:pattern)$ in cs-cs.js and cs-country.js, which is what 03944f2 did: main's version is kept, so that commit's code change is now redundant (its country test stays). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jmandel
added a commit
to jmandel/FHIRsmith
that referenced
this pull request
Nov 3, 2026
expand.js: both the prefetchCodes hint and HealthIntersections#335's text-filter search language on an exclude's concept list. A compose handed to processSelection now reports per-code properties through HealthIntersections#335's conceptProperties (only the names asked for), and a compose with a filter on a supplement-defined property is not handed over: the usual path evaluates it from the supplement. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jmandel
added a commit
to jmandel/FHIRsmith
that referenced
this pull request
Nov 3, 2026
…very word HealthIntersections#335 adds the codes whose supplement designations match a text filter to LOINC's and SNOMED CT's own matches (CodeSystemProvider._supplementSearchCodes). It tested each designation with SearchFilterText.passes, which is true when any one word of the filter matches, while the code system's own search needs every word. So with the Uzbek LOINC supplement loaded (language en), $expand of http://loinc.org/vs with filter "serum glucose" listed codes whose supplement text had either word: of the first 1,000, only 47 had "glucose" in their display. Before HealthIntersections#335 it listed none. SearchFilterText.passesAll matches each word as passes does (by stem), but needs all of them, and the supplement search uses it. Which supplements take part is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.